Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macOS] Packages fail to install #164

Closed
johnrichardrinehart opened this issue Jan 30, 2020 · 17 comments
Closed

[macOS] Packages fail to install #164

johnrichardrinehart opened this issue Jan 30, 2020 · 17 comments
Labels
bug Something isn't working MacOS Related to the MacOS operating system

Comments

@johnrichardrinehart
Copy link

johnrichardrinehart commented Jan 30, 2020

I have followed the shruggie package installation instructions after following the espanso package installation instructions for macOS and experienced the following behavior:

~ espanso install shruggie
Updating package index...
Index updated!
authentication required but no callback set; class=Ssh (23)
➜  ~ espanso restart
Daemon started correctly!~ espanso package list
➜  ~

I figured this authentication issue was related to SSH. So, I figured maybe I needed an SSH key loaded (my SSH keys are password-protected). But, ssh-add -l confirmed that my keys were already loaded by the agent. Also, the espanso hub only provides publicly-accessible code, so this shouldn't be an issue, it seems.

Note that I have repeated this for other packages, also. It's common across all packages that I tried.

@johnrichardrinehart johnrichardrinehart changed the title [Package] [macOS] Packages fail to install [macOS] Packages fail to install Jan 30, 2020
@federico-terzi
Copy link
Collaborator

Hey @johnrichardrinehart.

Thank you very much for your report. It seems like the library espanso currently uses to clone packages ( libgit2) , does not deal well with encrypted credentials.

I'll look at the problem as soon as I can and get back to you when I find something.

Thanks for your help :)

@federico-terzi federico-terzi added the bug Something isn't working label Jan 30, 2020
@federico-terzi
Copy link
Collaborator

Hey @johnrichardrinehart,
Unfortunately, I tried to reproduce your issue many times without success, it always works fine on my machine, even with encrypted ssh credentials.
Could it be that perhaps you encountered a temporary error not due to espanso?

Cheers :)

@johnrichardrinehart
Copy link
Author

Let me check in ~12 hours.

@johnrichardrinehart
Copy link
Author

@federico-terzi Please leave this open for a bit (if it's been more than a week since I can return to this then feel free to close it). I'm in the middle of a big sprint at work.

@federico-terzi
Copy link
Collaborator

No problem @johnrichardrinehart, take all the time you need :)

@unn
Copy link

unn commented Mar 11, 2020

Ran into this myself. Following along.

@johnrichardrinehart
Copy link
Author

@unn @federico-terzi I'm awful at making time for this. I'll do some tests within the next 30 hours.

@federico-terzi
Copy link
Collaborator

I'm sorry you both experienced issues guys. If we can't come up with a solution, I'll implement an alternative channel to install packages that doesn't depend on git, so that you can still install the packages.

Cheers :)

@unn
Copy link

unn commented Mar 12, 2020

No stress about timing from me, but thanks for being so on top of it.

@federico-terzi federico-terzi added the MacOS Related to the MacOS operating system label Mar 17, 2020
@federico-terzi
Copy link
Collaborator

Hey guys,

I'm currently pushing version 0.5.3 out with an alternative package provider which should work in your case. You can now download a package with the --no-git option:

espanso install <package_name> --no-git

Let me know if it works for you.

Cheers :)

@unn
Copy link

unn commented Mar 18, 2020

Works as expected!

@federico-terzi
Copy link
Collaborator

Works as expected!

Great! :) I'll keep the issue open as it shouldn't happen with the default provider and someone may come up with a solution in the future. At least now we have a backup plan.

Cheers :)

@johnrichardrinehart
Copy link
Author

@federico-terzi I forgot to post the results of my tests. I created a password-less RSA key, but 0.5.2 still failed to install packages with the same error code and message.

I've installed 0.5.3 and can confirm that --no-git works. Failure to use --no-git fails, though, still with the same error code and message

>  espanso install shruggie
Updating package index...
Index updated!
authentication required but no callback set; class=Ssh (23)

@federico-terzi
Copy link
Collaborator

Hey @johnrichardrinehart ,

Thank you for experimenting this further, at this point I can say quite confidently that password-protected RSA keys are not the cause of the issue (as it should be).

Cheers :)

@johnrichardrinehart
Copy link
Author

@federico-terzi That seems true. Thanks for issuing this new flag.

Do you know the cause of the problem?

@federico-terzi
Copy link
Collaborator

@johnrichardrinehart Unfortunately, I don't. I tried in many ways to reproduce the issue without any success...

@johnrichardrinehart
Copy link
Author

In the grand scheme of things that's just fine with me.

Thanks @federico-terzi .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working MacOS Related to the MacOS operating system
Projects
None yet
Development

No branches or pull requests

3 participants