Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Fix yamllint #440

Closed
wants to merge 12 commits into from
Closed

WIP: Fix yamllint #440

wants to merge 12 commits into from

Conversation

mgrachev
Copy link
Member

@mgrachev mgrachev commented Sep 1, 2021

✔ Checklist:

  • Commit messages have been written in Conventional Commits format;
  • This PR has been added to CHANGELOG.md (at the top of the list);
  • Tests for the changes have been added (for bug fixes / features);
  • Docs have been added / updated on the dotenv-linter.github.io (for bug fixes / features).

@mgrachev mgrachev changed the title chore: test linters WIP: Fix yamllint Sep 1, 2021
@github-actions
Copy link

github-actions bot commented Sep 1, 2021

Benchmark for 97f0613

Click to view benchmark
Test PR Benchmark Master Benchmark %
dotenv_linter check 71.0±3.19µs 68.7±2.32µs +3.35%
dotenv_linter compare 54.8±2.43µs 56.5±2.19µs -3.01%
dotenv_linter fix 200.7±10.09µs 208.3±38.05µs -3.65%
dotenv_linter fix with backup 307.3±272.84µs 281.7±119.89µs +9.09%

with:
github_token: ${{ secrets.github_token }}
reporter: github-pr-review
fail_on_error: true
yamllint_flags: '-d "{extends: default, rules: {truthy: disable}}" .'
#yamllint_flags: '-d "{extends: default, rules: {truthy: disable}}" .'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[yamllint] reported by reviewdog 🐶
[warning] missing starting space in comment (comments)

@github-actions
Copy link

github-actions bot commented Sep 1, 2021

Benchmark for 1fd5b81

Click to view benchmark
Test PR Benchmark Master Benchmark %
dotenv_linter check 67.3±8.06µs 69.7±2.06µs -3.44%
dotenv_linter compare 50.9±4.00µs 50.3±2.51µs +1.19%
dotenv_linter fix 210.1±71.25µs 216.2±89.94µs -2.82%
dotenv_linter fix with backup 257.3±86.18µs 273.2±124.58µs -5.82%

@github-actions
Copy link

github-actions bot commented Sep 1, 2021

Benchmark for f538966

Click to view benchmark
Test PR Benchmark Master Benchmark %
dotenv_linter check 68.7±0.35µs 69.1±0.23µs -0.58%
dotenv_linter compare 54.1±0.27µs 54.9±0.85µs -1.46%
dotenv_linter fix 174.4±70.53µs 177.3±106.80µs -1.64%
dotenv_linter fix with backup 213.8±150.44µs 236.8±179.36µs -9.71%

@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2021

Codecov Report

Merging #440 (18e4579) into master (017f954) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #440      +/-   ##
==========================================
- Coverage   98.95%   98.91%   -0.04%     
==========================================
  Files          40       40              
  Lines        2768     2767       -1     
==========================================
- Hits         2739     2737       -2     
- Misses         29       30       +1     
Impacted Files Coverage Δ
src/fs_utils.rs 95.45% <0.00%> (-1.14%) ⬇️
src/lint_kind.rs 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 017f954...18e4579. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Sep 1, 2021

Benchmark for cd71a07

Click to view benchmark
Test PR Benchmark Master Benchmark %
dotenv_linter check 69.5±2.74µs 68.0±3.09µs +2.21%
dotenv_linter compare 56.0±3.29µs 56.8±3.31µs -1.41%
dotenv_linter fix 204.6±42.17µs 194.6±71.37µs +5.14%
dotenv_linter fix with backup 281.9±163.62µs 283.5±166.78µs -0.56%

@github-actions
Copy link

github-actions bot commented Sep 1, 2021

Benchmark for 9a88120

Click to view benchmark
Test PR Benchmark Master Benchmark %
dotenv_linter check 68.1±5.55µs 61.3±3.92µs +11.09%
dotenv_linter compare 52.1±3.86µs 55.3±4.53µs -5.79%
dotenv_linter fix 226.3±92.25µs 199.5±23.61µs +13.43%
dotenv_linter fix with backup 283.1±183.42µs 275.4±100.19µs +2.80%

@dotenv-linter dotenv-linter deleted a comment from github-actions bot Sep 1, 2021
@github-actions
Copy link

github-actions bot commented Sep 1, 2021

Benchmark for 966b8a9

Click to view benchmark
Test PR Benchmark Master Benchmark %
dotenv_linter check 72.3±3.89µs 72.4±4.16µs -0.14%
dotenv_linter compare 55.1±2.67µs 58.2±2.93µs -5.33%
dotenv_linter fix 184.8±72.23µs 186.3±87.57µs -0.81%
dotenv_linter fix with backup 261.0±154.13µs 243.1±151.10µs +7.36%

@github-actions
Copy link

github-actions bot commented Sep 1, 2021

Benchmark for a9cbc3c

Click to view benchmark
Test PR Benchmark Master Benchmark %
dotenv_linter check 71.2±1.88µs 70.7±2.86µs +0.71%
dotenv_linter compare 59.9±1.84µs 56.0±3.35µs +6.96%
dotenv_linter fix 196.2±82.49µs 194.0±52.01µs +1.13%
dotenv_linter fix with backup 253.6±120.58µs 250.7±141.17µs +1.16%

@github-actions
Copy link

github-actions bot commented Sep 1, 2021

Benchmark for e9cbfbe

Click to view benchmark
Test PR Benchmark Master Benchmark %
dotenv_linter check 59.9±0.13µs 60.3±1.60µs -0.66%
dotenv_linter compare 43.1±0.12µs 48.2±0.33µs -10.58%
dotenv_linter fix 144.9±79.54µs 152.2±116.02µs -4.80%
dotenv_linter fix with backup 176.3±134.95µs 236.0±240.64µs -25.30%

@github-actions
Copy link

github-actions bot commented Sep 1, 2021

Benchmark for e9cbfbe

Click to view benchmark
Test PR Benchmark Master Benchmark %
dotenv_linter check 67.1±1.07µs 65.9±1.48µs +1.82%
dotenv_linter compare 53.8±1.03µs 52.6±1.75µs +2.28%
dotenv_linter fix 159.6±53.66µs 163.0±108.01µs -2.09%
dotenv_linter fix with backup 212.1±97.06µs 235.6±215.13µs -9.97%

@github-actions
Copy link

github-actions bot commented Sep 1, 2021

Benchmark for 166d6c5

Click to view benchmark
Test PR Benchmark Master Benchmark %
dotenv_linter check 69.5±4.10µs 68.1±4.21µs +2.06%
dotenv_linter compare 55.9±3.89µs 53.7±3.03µs +4.10%
dotenv_linter fix 196.3±91.30µs 200.3±61.76µs -2.00%
dotenv_linter fix with backup 254.6±128.46µs 257.7±118.13µs -1.20%

@github-actions
Copy link

github-actions bot commented Sep 1, 2021

Benchmark for 6216849

Click to view benchmark
Test PR Benchmark Master Benchmark %
dotenv_linter check 63.4±2.98µs 60.2±3.51µs +5.32%
dotenv_linter compare 51.7±3.54µs 49.5±3.42µs +4.44%
dotenv_linter fix 190.3±38.73µs 188.3±57.73µs +1.06%
dotenv_linter fix with backup 273.3±155.85µs 289.7±270.36µs -5.66%

with:
github_token: ${{ secrets.github_token }}
reporter: github-pr-review
fail_on_error: true
yamllint_flags: '-d "{extends: default, rules: {truthy: disable}}" .'
# yamllint_flags: "{extends: default}"
# yamllint_flags: '-d "{extends: default, rules: {truthy: disable}}" .'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[yamllint] reported by reviewdog 🐶
[error] line too long (81 > 80 characters) (line-length)

@github-actions
Copy link

github-actions bot commented Sep 1, 2021

Benchmark for b0acf18

Click to view benchmark
Test PR Benchmark Master Benchmark %
dotenv_linter check 66.4±1.07µs 68.4±1.14µs -2.92%
dotenv_linter compare 52.5±0.92µs 52.6±1.73µs -0.19%
dotenv_linter fix 172.6±100.72µs 158.4±60.35µs +8.96%
dotenv_linter fix with backup 222.5±129.28µs 240.6±210.02µs -7.52%

@github-actions
Copy link

github-actions bot commented Sep 1, 2021

Benchmark for 5e7e441

Click to view benchmark
Test PR Benchmark Master Benchmark %
dotenv_linter check 60.2±0.14µs 61.1±0.62µs -1.47%
dotenv_linter compare 48.9±0.18µs 48.3±0.16µs +1.24%
dotenv_linter fix 142.5±70.31µs 154.7±110.73µs -7.89%
dotenv_linter fix with backup 193.7±110.81µs 241.8±309.26µs -19.89%

@mgrachev
Copy link
Member Author

mgrachev commented Sep 8, 2021

The problem in the project reviewdog/action-yamllint#14

@mgrachev mgrachev closed this Sep 8, 2021
@mgrachev mgrachev deleted the fix-yamllint branch September 8, 2021 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants