@mstruebing Thank you for your contribution! 🔥 I like this feature too ❤️

I think we will merge it after release v2.2.0.

I have a few ideas how we can improve it, but I will come back with them a little later.

I think it would also make sense to do this as a separate subcommand after #333 🤔
What do you think? @dotenv-linter/core

This can also be done as a separate PR later on. Just a suggestion)

Multi-functional dotenv-linter👍

I think it would also make sense to do this as a separate subcommand after #333 🤔
What do you think? @dotenv-linter/core

This can also be done as a separate PR later on. Just a suggestion)

To tell the truth, I would like to merge this PR after #333

Multi-functional dotenv-linter👍

Yes, we are slowly moving towards this way 🙂

$ dotenv-linter check
$ dotenv-linter fix
$ dotenv-linter compare
$ dotenv-linter something_else

If you have ideas what else we can include in the next release, let me know 😉

I polished the PR a bit, feedback or desired changes are welcome

I think this PR is on hold until the subcommands are finished, right?

I think this PR is on hold until the subcommands are finished, right?

Yes, you are right 🙂

I think this PR is on hold until the subcommands are finished, right?

Subcommands are finished 🎉

I updated the PR right now as a subcommand

Codecov Report

Merging #282 (933d9bb) into master (20a7a3b) will increase coverage by 0.13%.
The diff coverage is 97.01%.

@@            Coverage Diff             @@
##           master     #282      +/-   ##
==========================================
+ Coverage   95.06%   95.19%   +0.13%     
==========================================
  Files          34       36       +2     
  Lines        2310     2373      +63     
==========================================
+ Hits         2196     2259      +63     
  Misses        114      114              

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20a7a3b...933d9bb. Read the comment docs.

@mstruebing Thank you!

Can you explain how this feature should work?
Also please give some examples.

Sure, so in general what it does:
You use the compare command and at least two files to compare (as I'm writing this I realize I need to make sure that you pass at least two files).
It then collects all keys of every environment file and compares if some of them are present in one file but not in the other.

I think this is handy for testing if different environments have some variables missing.

Also sometimes you have an .env.sample file in your repository. Which might get's updated and you miss to update your development environment file. Then you could quickly run dotenv-linter compare .env.sample .env and see which keys you might need to add. This is especially useful in bigger projects with lots of environment variables.

To try it out you can use the command in the first comment, just replace --compare with compare.

Do you have any further questions I did not answered?

Right now the output of the compare command looks like this:

$ dotenv-linter compare .env .env.local .env2
Comparing .env
Comparing .env.local
Comparing .env2
".env" is missing keys: "OK, MULTILINE"
".env.local" is missing keys: "OK, MULTILINE, 1MULTILINE, FOO, ZOO, WORLD"
".env2" is missing keys: "1MULTILINE, HELLO, ZOO, WORLD"

I would like to see something like this:

$ dotenv-linter compare .env .env.local .env2
Comparing .env
.env is missing keys: MULTILINE, OK

Comparing .env.local
.env.local is missing keys: FOO, 1MULTILINE, WORLD, MULTILINE, OK, ZOO

Comparing .env2
.env2 is missing keys: 1MULTILINE, HELLO, WORLD, ZOO

What do you think?

I think I adressed all of the review comments, still need to add some tests, however I have a problem now which I'm not able to fix:

src/lib.rs:154

        for line in lines {
            if let Some(key) = line.get_key() { // `line` does not live long enough: borrowed value does not live long enough
                all_keys.insert(key);
                keys.push(key)
            }
        }

What can I do to prevent this, I tried multiple things without success?

What can I do to prevent this, I tried multiple things without success?

Take a look at my comments above. I have sketched the fastest solution of your problem, but not the most efficient 😅

@dotenv-linter/core we should remember to add this to the documentation (dotenv-linter.github.io)

Sorry for the long delay, I just pushed:

• Tests for quiet mode
• simplifications by @DDtKey

Is there anything else I need to do except documentation?

Is there anything else I need to do except documentation?

I will add documentation for this command in dotenv-linter/dotenv-linter.github.io#16.

@mstruebing Excellent work 🔥Thank you 👏