Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[move-prover] Do not generate or use inline attr for uninterpreted functions #9208

Merged
merged 1 commit into from Sep 17, 2021
Merged

[move-prover] Do not generate or use inline attr for uninterpreted functions #9208

merged 1 commit into from Sep 17, 2021

Conversation

wrwg
Copy link
Contributor

@wrwg wrwg commented Sep 17, 2021

Both the code generator attached a {:inline} attribute to uninterpreted user spec functions, as well as the prelude declared is_txn_signer like this.

Closes #8995.

Motivation

Bug fix

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Manual

Related PRs

NA

@wrwg wrwg added this to In Progress in Move Prover via automation Sep 17, 2021
@bors-libra bors-libra added this to In Review in bors Sep 17, 2021
meng-xu-cs
meng-xu-cs previously approved these changes Sep 17, 2021
View reviewed changes
@wrwg
Copy link
Contributor Author

wrwg commented Sep 17, 2021

/land

@bors-libra bors-libra moved this from In Review to Queued in bors Sep 17, 2021
@wrwg @bors-libra
[move-prover] Do not generate or use inline attr for uninterpreted fu…
3ba55ff 
…nctions.

Both the code generator attached a `{:inline}` attribute to uninterpreted user spec functions, as well as the prelude declared is_txn_signer like this.

Closes diem#8995.

Closes: diem#9208
@bors-libra bors-libra moved this from Queued to Testing in bors Sep 17, 2021
@github-actions
Copy link

Cluster Test Result

Test runner setup time spent 283 secs
Compatibility test results for land_771c914e ==> land_3ba55ff1 (PR)
1. All instances running land_771c914e, generating some traffic on network
2. First full node land_771c914e ==> land_3ba55ff1, to validate new full node to old validator node traffic
3. First Validator node land_771c914e ==> land_3ba55ff1, to validate storage compatibility
4. First batch validators (14) land_771c914e ==> land_3ba55ff1, to test consensus and traffic between old full nodes and new validator node
5. First batch full nodes (14) land_771c914e ==> land_3ba55ff1
6. Second batch validators (15) land_771c914e ==> land_3ba55ff1, to upgrade rest of the validators
7. Second batch of full nodes (15) land_771c914e ==> land_3ba55ff1, to finish the network upgrade, time spent 633 secs
all up : 1161 TPS, 3911 ms latency, 4450 ms p99 latency, no expired txns, time spent 250 secs
Logs: http://kibana.ct-2-k8s-testnet.aws.hlw3truzy4ls.com/app/kibana#/discover?_g=(time:(from:'2021-09-17T19:44:22Z',to:'2021-09-17T20:05:43Z'))
Dashboard: http://grafana.ct-2-k8s-testnet.aws.hlw3truzy4ls.com/d/performance/performance?from=1631907862000&to=1631909143000
Validator 1 logs: http://kibana.ct-2-k8s-testnet.aws.hlw3truzy4ls.com/app/kibana#/discover?_g=(time:(from:'2021-09-17T19:44:22Z',to:'2021-09-17T20:05:43Z'))&_a=(columns:!(log),query:(language:kuery,query:'kubernetes.pod_name:"val-1"'),sort:!(!('@timestamp',desc)))

Repro cmd:

./scripts/cti --tag land_771c914e --cluster-test-tag land_3ba55ff1 -E BATCH_SIZE=15 -E UPDATE_TO_TAG=land_3ba55ff1 --report report.json --suite land_blocking_compat

🎉 Land-blocking cluster test passed! 👌

@bors-libra bors-libra removed this from Testing in bors Sep 17, 2021
@bors-libra bors-libra merged commit 3ba55ff into diem:main Sep 17, 2021
Move Prover automation moved this from In Progress to Closed Sep 17, 2021
@bors-libra bors-libra temporarily deployed to Sccache September 17, 2021 20:07 Inactive
@bors-libra bors-libra temporarily deployed to Sccache September 17, 2021 20:07 Inactive
@bors-libra bors-libra temporarily deployed to Docker September 17, 2021 20:07 Inactive
@wrwg wrwg deleted the 8995 branch October 1, 2021 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meng-xu-cs meng-xu-cs meng-xu-cs left review comments

@cbarrettfb cbarrettfb Awaiting requested review from cbarrettfb

Assignees
No one assigned
Labels
cla-signed
Projects
Move Prover
  
Closed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] [move-prover] ill-formed bpl file
3 participants
@wrwg @meng-xu-cs @bors-libra