[diem-framework] Add force shift event to CRSNs, add gate #9204
Conversation
tzakian
requested review from
phlip9,
msmouse,
sblackshear,
runtian-zhou and
bob-wilson
tzakian
force-pushed
the
force_shift_event_and_gate
branch
from
31c2c8d
to
3030fb2
Compare
| shift_amount: u64, | ||
| /// The state of the bitvector just before the shift (NB: the sequence | ||
| /// nonce of the shifting transaction will not be set). | ||
| bits_at_shift: BitVector, |
There was a problem hiding this comment.
random thought: is there any reason why the BitVector uses a vector<bool>? do we have a specialized compact serialization for that?
There was a problem hiding this comment.
nit: also maybe add a small comment on why we need the bits_at_shift here, like "the bitvector state is needed to prove that a CRSN slot was expired and not already consumed; therefore, a user transaction at that slot can't exist (because that slot was expired)."
There was a problem hiding this comment.
random thought: is there any reason why the BitVector uses a vector? do we have a specialized compact serialization for that?
Good question. The underlying bitvector representation can be compacted (e.g., to use vec<u64>), however verifying code that does computation around bitshifts is incredibly difficult, so there are issues with a more complex dense representation of these and we decided to go with vec<bool> for now.
tzakian
force-pushed
the
force_shift_event_and_gate
branch
from
3030fb2
to
d933b7f
Compare
| } | ||
|
|
||
| /// Whenever a force shift is performed a `ForceShiftEvent` is emitted. | ||
| /// This is used to prove the absence of a transaction at a specific sequence nonce. | ||
| struct ForceShiftEvent has drop, store { |
There was a problem hiding this comment.
Just to double check store here is to work with the phantom type parameter in the event handle?
There was a problem hiding this comment.
Correct! it needs a T: drop + store so this needs store to match up with those restrictions.
|
/land |
* Be able to be turned on after release * To emit a `ForceShiftEvent` whenever a force shift event occurs Closes: diem#9204
|
Cluster Test Result Repro cmd: 🎉 Land-blocking cluster test passed! 👌 |
bors-libra
force-pushed
the
force_shift_event_and_gate
branch
from
d933b7f
to
5f9d241
Compare
This PR updates CRSNs to:
ForceShiftEventwhenever a force shift event occursIt also adds tests to make sure that the gating is respected in the Framework, and that
ForceShiftEventsare emitted when force shifting.