Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Forge] Add forge LBT in ci-test #9039

Merged
merged 1 commit into from Sep 10, 2021
Merged

[Forge] Add forge LBT in ci-test #9039

merged 1 commit into from Sep 10, 2021

Conversation

zihaoccc
Copy link
Contributor

Motivation

(Write your motivation for proposed changes here.)

Have you read the Contributing Guidelines on pull requests?

(Write your answer here.)

Test Plan

(Share your test plan here. If you changed code, please provide us with clear instructions for verifying that your changes work.)

Related PRs

(If this PR adds or changes functionality, please take some time to update or suggest changes to the docs at https://developers.diem.com, and link to your PR here.)

If targeting a release branch, please fill the below out as well

  • Justification and breaking nature (who does it affect? validators, full nodes, tooling, operators, AOS, etc.)
  • Comprehensive test results that demonstrate the fix working and not breaking existing workflows.
  • Why we must have it for V1 launch.
  • What workarounds and alternative we have if we do not push the PR.

@bors-libra bors-libra added this to In Review in bors Aug 26, 2021
@zihaoccc
Copy link
Contributor Author

/canary

bors-libra pushed a commit that referenced this pull request Aug 26, 2021
@zihaoccc @bors-libra
[WIP][Forge] Add forge LBT in ci-test
8510af3 
Closes: #9039
@bors-libra bors-libra moved this from In Review to Canary in bors Aug 26, 2021
@bors-libra bors-libra moved this from Canary to In Review in bors Aug 26, 2021
@github-actions
Copy link

Cluster Test Result

Test runner setup time spent 340 secs
Compatibility test results for land_2f2eb8f1 ==> land_8510af30 (PR)
1. All instances running land_2f2eb8f1, generating some traffic on network
2. First full node land_2f2eb8f1 ==> land_8510af30, to validate new full node to old validator node traffic
3. First Validator node land_2f2eb8f1 ==> land_8510af30, to validate storage compatibility
4. First batch validators (14) land_2f2eb8f1 ==> land_8510af30, to test consensus and traffic between old full nodes and new validator node
5. First batch full nodes (14) land_2f2eb8f1 ==> land_8510af30
6. Second batch validators (15) land_2f2eb8f1 ==> land_8510af30, to upgrade rest of the validators
7. Second batch of full nodes (15) land_2f2eb8f1 ==> land_8510af30, to finish the network upgrade, time spent 653 secs
all up : 1245 TPS, 3646 ms latency, 4200 ms p99 latency, no expired txns, time spent 250 secs
Logs: http://kibana.ct-2-k8s-testnet.aws.hlw3truzy4ls.com/app/kibana#/discover?_g=(time:(from:'2021-08-26T23:12:29Z',to:'2021-08-26T23:36:07Z'))
Dashboard: http://grafana.ct-2-k8s-testnet.aws.hlw3truzy4ls.com/d/performance/performance?from=1630019549000&to=1630020967000
Validator 1 logs: http://kibana.ct-2-k8s-testnet.aws.hlw3truzy4ls.com/app/kibana#/discover?_g=(time:(from:'2021-08-26T23:12:29Z',to:'2021-08-26T23:36:07Z'))&_a=(columns:!(log),query:(language:kuery,query:'kubernetes.pod_name:"val-1"'),sort:!(!('@timestamp',desc)))

Repro cmd:

./scripts/cti --tag land_2f2eb8f1 --cluster-test-tag land_8510af30 -E BATCH_SIZE=15 -E UPDATE_TO_TAG=land_8510af30 --report report.json --suite land_blocking_compat

🎉 Land-blocking cluster test passed! 👌

@zihaoccc
Copy link
Contributor Author

/canary

bors-libra pushed a commit that referenced this pull request Aug 27, 2021
@zihaoccc @bors-libra
added stdout for subprocess
78bc68d 
Closes: #9039
@bors-libra bors-libra moved this from In Review to Canary in bors Aug 27, 2021
@bors-libra
Copy link
Contributor

💔 Test Failed - ci-test

@bors-libra bors-libra moved this from Canary to In Review in bors Aug 27, 2021
@zihaoccc
Copy link
Contributor Author

/canary

bors-libra pushed a commit that referenced this pull request Aug 27, 2021
@zihaoccc @bors-libra
temp change to bypass forge build
70001ce 
Closes: #9039
@bors-libra bors-libra moved this from In Review to Canary in bors Aug 27, 2021
@github-actions
Copy link

Cluster Test Result

Test runner setup time spent 252 secs
Compatibility test results for land_6ad78090 ==> land_70001ce4 (PR)
1. All instances running land_6ad78090, generating some traffic on network
2. First full node land_6ad78090 ==> land_70001ce4, to validate new full node to old validator node traffic
3. First Validator node land_6ad78090 ==> land_70001ce4, to validate storage compatibility
4. First batch validators (14) land_6ad78090 ==> land_70001ce4, to test consensus and traffic between old full nodes and new validator node
5. First batch full nodes (14) land_6ad78090 ==> land_70001ce4
6. Second batch validators (15) land_6ad78090 ==> land_70001ce4, to upgrade rest of the validators
7. Second batch of full nodes (15) land_6ad78090 ==> land_70001ce4, to finish the network upgrade, time spent 696 secs
all up : 1258 TPS, 3602 ms latency, 4200 ms p99 latency, no expired txns, time spent 249 secs
Logs: http://kibana.ct-1-k8s-testnet.aws.hlw3truzy4ls.com/app/kibana#/discover?_g=(time:(from:'2021-08-27T21:41:34Z',to:'2021-08-27T22:03:28Z'))
Dashboard: http://grafana.ct-1-k8s-testnet.aws.hlw3truzy4ls.com/d/performance/performance?from=1630100494000&to=1630101808000
Validator 1 logs: http://kibana.ct-1-k8s-testnet.aws.hlw3truzy4ls.com/app/kibana#/discover?_g=(time:(from:'2021-08-27T21:41:34Z',to:'2021-08-27T22:03:28Z'))&_a=(columns:!(log),query:(language:kuery,query:'kubernetes.pod_name:"val-1"'),sort:!(!('@timestamp',desc)))

Repro cmd:

./scripts/cti --tag land_6ad78090 --cluster-test-tag land_70001ce4 -E BATCH_SIZE=15 -E UPDATE_TO_TAG=land_70001ce4 --report report.json --suite land_blocking_compat

🎉 Land-blocking cluster test passed! 👌

@bors-libra bors-libra moved this from Canary to In Review in bors Aug 27, 2021
@zihaoccc
Copy link
Contributor Author

/canary

@bors-libra bors-libra moved this from In Review to Canary in bors Aug 27, 2021
bors-libra pushed a commit that referenced this pull request Aug 27, 2021
@zihaoccc @bors-libra
added stdout for subprocess
dac7032 
Closes: #9039
@bors-libra
Copy link
Contributor

💔 Test Failed - ci-test

@bors-libra bors-libra moved this from Canary to In Review in bors Aug 27, 2021
@zihaoccc
Copy link
Contributor Author

/canary

@bors-libra bors-libra moved this from In Review to Canary in bors Aug 31, 2021
bors-libra pushed a commit that referenced this pull request Aug 31, 2021
@zihaoccc @bors-libra
added stdout for subprocess
63fb2c3 
Closes: #9039
@bors-libra
Copy link
Contributor

💔 Test Failed - ci-test

@bors-libra bors-libra moved this from Canary to In Review in bors Aug 31, 2021
@bors-libra bors-libra moved this from Queued to Testing in bors Sep 10, 2021
@github-actions
Copy link

Cluster Test Result

Test runner setup time spent 255 secs
Compatibility test results for land_00df1469 ==> land_cab74900 (PR)
1. All instances running land_00df1469, generating some traffic on network
2. First full node land_00df1469 ==> land_cab74900, to validate new full node to old validator node traffic
3. First Validator node land_00df1469 ==> land_cab74900, to validate storage compatibility
4. First batch validators (14) land_00df1469 ==> land_cab74900, to test consensus and traffic between old full nodes and new validator node
5. First batch full nodes (14) land_00df1469 ==> land_cab74900
6. Second batch validators (15) land_00df1469 ==> land_cab74900, to upgrade rest of the validators
7. Second batch of full nodes (15) land_00df1469 ==> land_cab74900, to finish the network upgrade, time spent 691 secs
all up : 1216 TPS, 3731 ms latency, 4200 ms p99 latency, no expired txns, time spent 250 secs
Logs: http://kibana.ct-1-k8s-testnet.aws.hlw3truzy4ls.com/app/kibana#/discover?_g=(time:(from:'2021-09-10T17:53:54Z',to:'2021-09-10T18:15:57Z'))
Dashboard: http://grafana.ct-1-k8s-testnet.aws.hlw3truzy4ls.com/d/performance/performance?from=1631296434000&to=1631297757000
Validator 1 logs: http://kibana.ct-1-k8s-testnet.aws.hlw3truzy4ls.com/app/kibana#/discover?_g=(time:(from:'2021-09-10T17:53:54Z',to:'2021-09-10T18:15:57Z'))&_a=(columns:!(log),query:(language:kuery,query:'kubernetes.pod_name:"val-1"'),sort:!(!('@timestamp',desc)))

Repro cmd:

./scripts/cti --tag land_00df1469 --cluster-test-tag land_cab74900 -E BATCH_SIZE=15 -E UPDATE_TO_TAG=land_cab74900 --report report.json --suite land_blocking_compat

🎉 Land-blocking cluster test passed! 👌

@bors-libra bors-libra removed this from Testing in bors Sep 10, 2021
@bors-libra bors-libra merged commit cab7490 into diem:main Sep 10, 2021
@bors-libra bors-libra temporarily deployed to Sccache September 10, 2021 18:23 Inactive
@bors-libra bors-libra temporarily deployed to Sccache September 10, 2021 18:24 Inactive
@bors-libra bors-libra temporarily deployed to Docker September 10, 2021 18:24 Inactive
vikalpacn pushed a commit to vikalpacn/work that referenced this pull request Jan 4, 2023
@zihaoccc @vikalpacn
[Forge] Add forge LBT in ci-test
cc83571 
Closes: diem#9039
@vikalpacn vikalpacn mentioned this pull request Jan 4, 2023
Closed
bors-diem pushed a commit that referenced this pull request Jan 4, 2023
@zihaoccc @bors-diem
[Forge] Add forge LBT in ci-test
afcbad3 
Closes: #9039
bors-diem pushed a commit that referenced this pull request Jan 5, 2023
@zihaoccc @bors-diem
[Forge] Add forge LBT in ci-test
efb2911 
Closes: #9039
bors-diem pushed a commit that referenced this pull request Jan 5, 2023
@zihaoccc @bors-diem
[Forge] Add forge LBT in ci-test
d744980 
Closes: #9039
@satyamacn satyamacn mentioned this pull request Jan 6, 2023
Closed
bors-diem pushed a commit that referenced this pull request Jan 6, 2023
@zihaoccc @bors-diem
[Forge] Add forge LBT in ci-test
6837d0c 
Closes: #9039
bors-diem pushed a commit that referenced this pull request Jan 6, 2023
@zihaoccc @bors-diem
[Forge] Add forge LBT in ci-test
94d9b25 
Closes: #9039
bors-diem pushed a commit that referenced this pull request Jan 6, 2023
@zihaoccc @bors-diem
[Forge] Add forge LBT in ci-test
545cf52 
Closes: #9039
@satyamacn satyamacn mentioned this pull request Jan 9, 2023
Closed
bors-diem pushed a commit that referenced this pull request Jan 9, 2023
@zihaoccc @bors-diem
[Forge] Add forge LBT in ci-test
fdb6e38 
Closes: #9039
@satyamacn satyamacn mentioned this pull request Jan 9, 2023
Merged
bors-diem pushed a commit that referenced this pull request Jan 10, 2023
@zihaoccc @bors-diem
[Forge] Add forge LBT in ci-test
cbffbbb 
Closes: #9039
bors-diem pushed a commit that referenced this pull request Jan 10, 2023
@zihaoccc @bors-diem
[Forge] Add forge LBT in ci-test
ed4aebf 
Closes: #9039
bors-diem pushed a commit that referenced this pull request Jan 11, 2023
@zihaoccc @bors-diem
[Forge] Add forge LBT in ci-test
80f3bbb 
Closes: #9039
Closes: #10701
bors-diem pushed a commit that referenced this pull request Jan 11, 2023
@zihaoccc @bors-diem
[Forge] Add forge LBT in ci-test
c8e38b1 
Closes: #9039
Closes: #10701
bors-diem pushed a commit that referenced this pull request Jan 12, 2023
@zihaoccc @bors-diem
[Forge] Add forge LBT in ci-test
8620f1e 
Closes: #9039
Closes: #10701
bors-diem pushed a commit that referenced this pull request Jan 12, 2023
@zihaoccc @bors-diem
[Forge] Add forge LBT in ci-test
82cf92a 
Closes: #9039
Closes: #10701
bors-diem pushed a commit that referenced this pull request Jan 12, 2023
@zihaoccc @bors-diem
[Forge] Add forge LBT in ci-test
aca82e2 
Closes: #9039
Closes: #10701
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmwill bmwill bmwill left review comments

@rustielin rustielin Awaiting requested review from rustielin

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zihaoccc @bors-libra @bmwill