WIP #7918

zihaoccc · 2021-03-12T23:57:33Z

Motivation

(Write your motivation for proposed changes here.)

Have you read the Contributing Guidelines on pull requests?

(Write your answer here.)

Test Plan

(Share your test plan here. If you changed code, please provide us with clear instructions for verifying that your changes work.)

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/diem/diem/tree/main/developers.diem.com, and link to your PR here.)

If targeting a release branch, please fill the below out as well

Justification and breaking nature (who does it affect? validators, full nodes, tooling, operators, AOS, etc.)
Comprehensive test results that demonstrate the fix working and not breaking existing workflows.
Why we must have it for V1 launch.
What workarounds and alternative we have if we do not push the PR.

zihaoccc · 2021-03-14T03:48:11Z

/canary

Closes: #7918

bors-libra · 2021-03-14T04:16:58Z

💔 Test Failed - ci-test-success

zihaoccc · 2021-03-14T04:19:30Z

/canary

Closes: #7918

bors-libra · 2021-03-14T04:46:44Z

💔 Test Failed - ci-test-success

zihaoccc · 2021-03-14T05:01:38Z

/canary

Closes: #7918

bors-libra · 2021-03-14T05:28:44Z

💔 Test Failed - ci-test-success

zihaoccc · 2021-03-14T05:30:29Z

/canary

Closes: #7918

zihaoccc · 2021-03-14T05:54:32Z

/canary

Closes: #7918

zihaoccc · 2021-03-14T06:34:51Z

/canary

Closes: #7918

zihaoccc · 2021-03-16T02:40:32Z

/canary

Closes: #7918

github-actions · 2021-03-16T03:15:13Z

Cluster Test Result

Test runner setup time spent 250 secs
all up : 949 TPS, 4786 ms latency, 5500 ms p99 latency, no expired txns, time spent 270 secs
Logs: http://kibana.ct-1-k8s-testnet.aws.hlw3truzy4ls.com/app/kibana#/discover?_g=(time:(from:'2021-03-16T03:04:38Z',to:'2021-03-16T03:15:13Z'))
Dashboard: http://grafana.ct-1-k8s-testnet.aws.hlw3truzy4ls.com/d/performance/performance?from=1615863878000&to=1615864513000
Validator 1 logs: http://kibana.ct-1-k8s-testnet.aws.hlw3truzy4ls.com/app/kibana#/discover?_g=(time:(from:'2021-03-16T03:04:38Z',to:'2021-03-16T03:15:13Z'))&_a=(columns:!(log),query:(language:kuery,query:'kubernetes.pod_name:"val-1"'),sort:!(!('@timestamp',desc)))

Repro cmd:

./scripts/cti --tag land_1428fabc -E RUST_LOG=debug --report report.json --suite land_blocking

🎉 Land-blocking cluster test passed! 👌

bors-libra · 2021-03-16T03:15:35Z

☀️ Canary successful

zihaoccc · 2021-03-16T03:19:05Z

/canary

Closes: #7918

github-actions · 2021-03-16T03:53:51Z

Cluster Test Result

Test runner setup time spent 265 secs
all up : 949 TPS, 4792 ms latency, 5550 ms p99 latency, no expired txns, time spent 271 secs
Logs: http://kibana.ct-1-k8s-testnet.aws.hlw3truzy4ls.com/app/kibana#/discover?_g=(time:(from:'2021-03-16T03:42:56Z',to:'2021-03-16T03:53:50Z'))
Dashboard: http://grafana.ct-1-k8s-testnet.aws.hlw3truzy4ls.com/d/performance/performance?from=1615866176000&to=1615866830000
Validator 1 logs: http://kibana.ct-1-k8s-testnet.aws.hlw3truzy4ls.com/app/kibana#/discover?_g=(time:(from:'2021-03-16T03:42:56Z',to:'2021-03-16T03:53:50Z'))&_a=(columns:!(log),query:(language:kuery,query:'kubernetes.pod_name:"val-1"'),sort:!(!('@timestamp',desc)))

Repro cmd:

./scripts/cti --tag land_02cfb63e -E RUST_LOG=debug --report report.json --suite land_blocking

🎉 Land-blocking cluster test passed! 👌

bors-libra · 2021-03-16T03:54:09Z

☀️ Canary successful

libra-action · 2021-03-16T17:39:12Z

LSR dependency change summary:

host packages:
  M syn 1.0.64 (direct third-party, crates.io)
    * version upgraded from 1.0.62
    * (unchanged features: clone-impls, default, derive, extra-traits, full, parsing, printing, proc-macro, quote, visit)

libra-action · 2021-03-16T17:39:13Z

LEC dependency change summary:

host packages:
  M syn 1.0.64 (direct third-party, crates.io)
    * version upgraded from 1.0.62
    * (unchanged features: clone-impls, default, derive, extra-traits, full, parsing, printing, proc-macro, quote, visit, visit-mut)

libra-action · 2021-03-16T17:39:13Z

release binaries dependency change summary:

target packages:
  A move-stdlib 0.1.0 (workspace, path 'language/move-stdlib')
    * features: [none]
  M serde-generate 0.19.1 (direct third-party, crates.io)
    * version upgraded from 0.19.0
    * (unchanged features: [none])
  M regex-syntax 0.6.23 (transitive third-party, crates.io)
    * version upgraded from 0.6.22
    * (unchanged features: default, unicode, unicode-age, unicode-bool, unicode-case, unicode-gencat, unicode-perl, unicode-script, unicode-segment)

host packages:
  M syn 1.0.64 (direct third-party, crates.io)
    * version upgraded from 1.0.62
    * (unchanged features: clone-impls, default, derive, extra-traits, fold, full, parsing, printing, proc-macro, quote, visit, visit-mut)
  M regex-syntax 0.6.23 (transitive third-party, crates.io)
    * version upgraded from 0.6.22
    * (unchanged features: default, unicode, unicode-age, unicode-bool, unicode-case, unicode-gencat, unicode-perl, unicode-script, unicode-segment)

MIRAI-bot · 2021-03-16T17:46:51Z

Hey hey!

It looks like #wannabe-land-blocking found some issues that are not yet land blocking, but will be in the future.
Please fix these:

click here to reveal them

warning: integer arithmetic detected
   --> execution/executor-benchmark/src/lib.rs:298:13
    |
298 |             total_transactions += num_txns;
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#integer_arithmetic
warning: integer arithmetic detected

--> language/move-core/types/src/account_address.rs:56:22

|

56 |         if hex_len < Self::LENGTH * 2 {

|                      ^^^^^^^^^^^^^^^^

|

= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#integer_arithmetic
warning: integer arithmetic detected

--> language/move-core/types/src/account_address.rs:57:53

|

57 |             let mut hex_str = String::with_capacity(Self::LENGTH * 2);

|                                                     ^^^^^^^^^^^^^^^^

|

= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#integer_arithmetic
warning: integer arithmetic detected

--> language/move-core/types/src/account_address.rs:58:25

|

58 |             for _ in 0..Self::LENGTH * 2 - hex_len {

|                         ^^^^^^^^^^^^^^^^^^^^^^^^^^

|

= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#integer_arithmetic
warning: integer arithmetic detected

--> language/move-lang/src/naming/uses.rs:157:22

|

157 |     let node = cycle[len - 2];

|                      ^^^^^^^

|

= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#integer_arithmetic
warning: integer arithmetic detected

--> language/move-lang/src/naming/uses.rs:158:26

|

158 |     let neighbor = cycle[len - 1];

|                          ^^^^^^^

|

= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#integer_arithmetic
warning: integer arithmetic detected

--> language/move-lang/src/to_bytecode/translate.rs:72:29

|

72 |         orderings.insert(m, mdef.dependency_order + 1 + max_ordering);

|                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

|

= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#integer_arithmetic
warning: integer arithmetic detected

--> testsuite/cluster-test/src/experiments/versioning_test.rs:215:9

|

215 |         diem_root_account.sequence_number += 1;

|         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

|

= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#integer_arithmetic
warning: integer arithmetic detected

--> testsuite/cluster-test/src/experiments/versioning_test.rs:221:9

|

221 |         account.sequence_number += 1;

|         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^

|

= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#integer_arithmetic
warning: integer arithmetic detected

--> testsuite/cluster-test/src/experiments/versioning_test.rs:229:29

|

229 |         Duration::from_secs(15 * 60)

|                             ^^^^^^^

|

= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#integer_arithmetic

bors-libra added this to In Review in bors Mar 12, 2021

diem-cla-bot bot added the cla-signed label Mar 12, 2021

zihaoccc force-pushed the test_p1 branch from 5cf0404 to be2a89e Compare March 14, 2021 03:28