Rename all the things from libra to diem #6798

tzakian · 2020-12-03T18:54:09Z

Renames all occurrences of "libra" with "diem" (with casing preserved).
Renames all occurrences of "lbr" with "XDX" (with casing preserved).
Renames all occurences of "coin1" to "XUS" (with casing preserved).

This PR is meant to be the bulk renaming, there will need to be smaller cleanup passes that we will want to do afterwards, but that can be done by folks in each area.

sherry-x · 2020-12-03T19:05:39Z

libra.org -> diem.com, diem.org doesn't exist.

Cargo.toml

CONTRIBUTING.md

docker/compose/public_full_node/docker-compose.yaml

docker/compose/validator-testnet/docker-compose.yaml

docker/compose/mint/docker-compose.yaml

README.md

tzakian · 2020-12-04T18:00:53Z

config/management/operational/src/network_checker.rs

-    use libra_network_address::NetworkAddress;
-    use libra_types::chain_id::ChainId;
+    use diem_network_address::NetworkAddress;
+    use diem_types::chain_id::ChainId;


@JoshLind I had to keep the libra and libra.org names below for the network addreses. Just want to make sure this is OK/that you're aware.

@tzakian, this should be fine -- we can clean it up later 😄 Out of curiosity, did the test fail if you changed them?

Yea, sadly the test failed if they are changed :( So figured best to switch them back for now :)

Awesome, thanks! 😄

docker/build_push.sh

docker/dockerhub_to_novi_ecr.sh

docker/init/buildspec.yaml

docker/mint/buildspec.yaml

docker/safety-rules/buildspec.yaml

docker/tools/buildspec.yaml

docker/validator/buildspec.yaml

aching

Minor comments for things that can be done later if this is good to go.

CONTRIBUTING.md

config/README.md

tzakian · 2020-12-07T17:05:24Z

/cancel

bors-libra · 2020-12-07T17:05:24Z

❗ Land has been canceled due to this PR being updated with new commits. Please issue another Land command if you want to requeue this PR.

tzakian · 2020-12-07T17:05:45Z

/land
/priority=high
/priority high

Closes: #6798

libra-action · 2020-12-07T17:11:37Z

LEC dependency change summary:

target packages:
  A diem-config 0.1.0 (workspace, path 'config')
    * features: default
  A diem-crypto 0.1.0 (workspace, path 'crypto/crypto')
    * features: curve25519-dalek, default, ed25519-dalek, fiat, x25519-dalek
  A diem-github-client 0.1.0 (workspace, path 'secure/storage/github')
    * features: [none]
  A diem-global-constants 0.1.0 (workspace, path 'config/global-constants')
    * features: [none]
  A diem-infallible 0.1.0 (workspace, path 'common/infallible')
    * features: [none]
  A diem-logger 0.1.0 (workspace, path 'common/logger')
    * features: [none]
  A diem-metrics 0.1.0 (workspace, path 'common/metrics')
    * features: [none]
  A diem-metrics-core 0.1.0 (workspace, path 'common/metrics-core')
    * features: [none]
  A diem-network-address 0.1.0 (workspace, path 'network/network-address')
    * features: default
  A diem-network-address-encryption 0.1.0 (workspace, path 'config/management/network-address-encryption')
    * features: [none]
  A diem-nibble 0.1.0 (workspace, path 'common/nibble')
    * features: default
  A diem-secure-net 0.1.0 (workspace, path 'secure/net')
    * features: [none]
  A diem-secure-push-metrics 0.1.0 (workspace, path 'secure/push-metrics')
    * features: [none]
  A diem-secure-storage 0.1.0 (workspace, path 'secure/storage')
    * features: [none]
  A diem-secure-time 0.1.0 (workspace, path 'secure/time')
    * features: [none]
  A diem-state-view 0.1.0 (workspace, path 'storage/state-view')
    * features: default
  A diem-temppath 0.1.0 (workspace, path 'common/temppath')
    * features: [none]
  A diem-trace 0.1.0 (workspace, path 'common/trace')
    * features: [none]
  A diem-types 0.1.0 (workspace, path 'types')
    * features: default
  A diem-vault-client 0.1.0 (workspace, path 'secure/storage/vault')
    * features: [none]
  A diem-vm 0.1.0 (workspace, path 'language/diem-vm')
    * features: default
  R libra-config 0.1.0 (workspace, path 'config')
    * (old features: default)
  R libra-crypto 0.1.0 (workspace, path 'crypto/crypto')
    * (old features: curve25519-dalek, default, ed25519-dalek, fiat, x25519-dalek)
  R libra-github-client 0.1.0 (workspace, path 'secure/storage/github')
    * (old features: [none])
  R libra-global-constants 0.1.0 (workspace, path 'config/global-constants')
    * (old features: [none])
  R libra-infallible 0.1.0 (workspace, path 'common/infallible')
    * (old features: [none])
  R libra-logger 0.1.0 (workspace, path 'common/logger')
    * (old features: [none])
  R libra-metrics 0.1.0 (workspace, path 'common/metrics')
    * (old features: [none])
  R libra-metrics-core 0.1.0 (workspace, path 'common/metrics-core')
    * (old features: [none])
  R libra-network-address 0.1.0 (workspace, path 'network/network-address')
    * (old features: default)
  R libra-network-address-encryption 0.1.0 (workspace, path 'config/management/network-address-encryption')
    * (old features: [none])
  R libra-nibble 0.1.0 (workspace, path 'common/nibble')
    * (old features: default)
  R libra-secure-net 0.1.0 (workspace, path 'secure/net')
    * (old features: [none])
  R libra-secure-push-metrics 0.1.0 (workspace, path 'secure/push-metrics')
    * (old features: [none])
  R libra-secure-storage 0.1.0 (workspace, path 'secure/storage')
    * (old features: [none])
  R libra-secure-time 0.1.0 (workspace, path 'secure/time')
    * (old features: [none])
  R libra-state-view 0.1.0 (workspace, path 'storage/state-view')
    * (old features: default)
  R libra-temppath 0.1.0 (workspace, path 'common/temppath')
    * (old features: [none])
  R libra-trace 0.1.0 (workspace, path 'common/trace')
    * (old features: [none])
  R libra-types 0.1.0 (workspace, path 'types')
    * (old features: default)
  R libra-vault-client 0.1.0 (workspace, path 'secure/storage/vault')
    * (old features: [none])
  R libra-vm 0.1.0 (workspace, path 'language/libra-vm')
    * (old features: default)

host packages:
  A diem-crypto-derive 0.1.0 (workspace, path 'crypto/crypto-derive')
    * features: [none]
  A diem-log-derive 0.1.0 (workspace, path 'common/logger/derive')
    * features: [none]
  R libra-crypto-derive 0.1.0 (workspace, path 'crypto/crypto-derive')
    * (old features: [none])
  R libra-log-derive 0.1.0 (workspace, path 'common/logger/derive')
    * (old features: [none])

libra-action · 2020-12-07T17:11:37Z

release binaries dependency change summary:

target packages:
  A diem-genesis-tool 0.1.0 (initial, path 'config/management/genesis')
    * features: testing
  A diem-key-manager 0.1.0 (initial, path 'secure/key-manager')
    * features: [none]
  A diem-node 0.1.0 (initial, path 'diem-node')
    * features: default
  A diem-bitvec 0.1.0 (workspace, path 'common/bitvec')
    * features: [none]
  A diem-config 0.1.0 (workspace, path 'config')
    * features: default
  A diem-crypto 0.1.0 (workspace, path 'crypto/crypto')
    * features: curve25519-dalek, default, ed25519-dalek, fiat, x25519-dalek
  A diem-github-client 0.1.0 (workspace, path 'secure/storage/github')
    * features: [none]
  A diem-global-constants 0.1.0 (workspace, path 'config/global-constants')
    * features: [none]
  A diem-infallible 0.1.0 (workspace, path 'common/infallible')
    * features: [none]
  A diem-jellyfish-merkle 0.1.0 (workspace, path 'storage/jellyfish-merkle')
    * features: default
  A diem-json-rpc 0.1.0 (workspace, path 'json-rpc')
    * features: [none]
  A diem-json-rpc-types 0.1.0 (workspace, path 'json-rpc/types')
    * features: [none]
  A diem-logger 0.1.0 (workspace, path 'common/logger')
    * features: [none]
  A diem-management 0.1.0 (workspace, path 'config/management')
    * features: [none]
  A diem-mempool 0.1.0 (workspace, path 'mempool')
    * features: default
  A diem-metrics 0.1.0 (workspace, path 'common/metrics')
    * features: [none]
  A diem-metrics-core 0.1.0 (workspace, path 'common/metrics-core')
    * features: [none]
  A diem-network-address 0.1.0 (workspace, path 'network/network-address')
    * features: default
  A diem-network-address-encryption 0.1.0 (workspace, path 'config/management/network-address-encryption')
    * features: [none]
  A diem-nibble 0.1.0 (workspace, path 'common/nibble')
    * features: default
  A diem-secure-json-rpc 0.1.0 (workspace, path 'secure/json-rpc')
    * features: [none]
  A diem-secure-net 0.1.0 (workspace, path 'secure/net')
    * features: [none]
  A diem-secure-push-metrics 0.1.0 (workspace, path 'secure/push-metrics')
    * features: [none]
  A diem-secure-storage 0.1.0 (workspace, path 'secure/storage')
    * features: [none]
  A diem-secure-time 0.1.0 (workspace, path 'secure/time')
    * features: [none]
  A diem-state-view 0.1.0 (workspace, path 'storage/state-view')
    * features: default
  A diem-temppath 0.1.0 (workspace, path 'common/temppath')
    * features: [none]
  A diem-trace 0.1.0 (workspace, path 'common/trace')
    * features: [none]
  A diem-types 0.1.0 (workspace, path 'types')
    * features: default
  A diem-vault-client 0.1.0 (workspace, path 'secure/storage/vault')
    * features: [none]
  A diem-vm 0.1.0 (workspace, path 'language/diem-vm')
    * features: default
  A diemdb 0.1.0 (workspace, path 'storage/diemdb')
    * features: default
  R libra-genesis-tool 0.1.0 (initial, path 'config/management/genesis')
    * (old features: testing)
  R libra-key-manager 0.1.0 (initial, path 'secure/key-manager')
    * (old features: [none])
  R libra-node 0.1.0 (initial, path 'libra-node')
    * (old features: default)
  R libra-bitvec 0.1.0 (workspace, path 'common/bitvec')
    * (old features: [none])
  R libra-config 0.1.0 (workspace, path 'config')
    * (old features: default)
  R libra-crypto 0.1.0 (workspace, path 'crypto/crypto')
    * (old features: curve25519-dalek, default, ed25519-dalek, fiat, x25519-dalek)
  R libra-github-client 0.1.0 (workspace, path 'secure/storage/github')
    * (old features: [none])
  R libra-global-constants 0.1.0 (workspace, path 'config/global-constants')
    * (old features: [none])
  R libra-infallible 0.1.0 (workspace, path 'common/infallible')
    * (old features: [none])
  R libra-jellyfish-merkle 0.1.0 (workspace, path 'storage/jellyfish-merkle')
    * (old features: default)
  R libra-json-rpc 0.1.0 (workspace, path 'json-rpc')
    * (old features: [none])
  R libra-json-rpc-types 0.1.0 (workspace, path 'json-rpc/types')
    * (old features: [none])
  R libra-logger 0.1.0 (workspace, path 'common/logger')
    * (old features: [none])
  R libra-management 0.1.0 (workspace, path 'config/management')
    * (old features: [none])
  R libra-mempool 0.1.0 (workspace, path 'mempool')
    * (old features: default)
  R libra-metrics 0.1.0 (workspace, path 'common/metrics')
    * (old features: [none])
  R libra-metrics-core 0.1.0 (workspace, path 'common/metrics-core')
    * (old features: [none])
  R libra-network-address 0.1.0 (workspace, path 'network/network-address')
    * (old features: default)
  R libra-network-address-encryption 0.1.0 (workspace, path 'config/management/network-address-encryption')
    * (old features: [none])
  R libra-nibble 0.1.0 (workspace, path 'common/nibble')
    * (old features: default)
  R libra-secure-json-rpc 0.1.0 (workspace, path 'secure/json-rpc')
    * (old features: [none])
  R libra-secure-net 0.1.0 (workspace, path 'secure/net')
    * (old features: [none])
  R libra-secure-push-metrics 0.1.0 (workspace, path 'secure/push-metrics')
    * (old features: [none])
  R libra-secure-storage 0.1.0 (workspace, path 'secure/storage')
    * (old features: [none])
  R libra-secure-time 0.1.0 (workspace, path 'secure/time')
    * (old features: [none])
  R libra-state-view 0.1.0 (workspace, path 'storage/state-view')
    * (old features: default)
  R libra-temppath 0.1.0 (workspace, path 'common/temppath')
    * (old features: [none])
  R libra-trace 0.1.0 (workspace, path 'common/trace')
    * (old features: [none])
  R libra-types 0.1.0 (workspace, path 'types')
    * (old features: default)
  R libra-vault-client 0.1.0 (workspace, path 'secure/storage/vault')
    * (old features: [none])
  R libra-vm 0.1.0 (workspace, path 'language/libra-vm')
    * (old features: default)
  R libradb 0.1.0 (workspace, path 'storage/libradb')
    * (old features: default)

host packages:
  A diem-crypto-derive 0.1.0 (workspace, path 'crypto/crypto-derive')
    * features: [none]
  A diem-log-derive 0.1.0 (workspace, path 'common/logger/derive')
    * features: [none]
  R libra-crypto-derive 0.1.0 (workspace, path 'crypto/crypto-derive')
    * (old features: [none])
  R libra-log-derive 0.1.0 (workspace, path 'common/logger/derive')
    * (old features: [none])

libra-action · 2020-12-07T17:11:39Z

LSR dependency change summary:

target packages:
  A diem-config 0.1.0 (workspace, path 'config')
    * features: default
  A diem-crypto 0.1.0 (workspace, path 'crypto/crypto')
    * features: curve25519-dalek, default, ed25519-dalek, fiat, x25519-dalek
  A diem-github-client 0.1.0 (workspace, path 'secure/storage/github')
    * features: [none]
  A diem-global-constants 0.1.0 (workspace, path 'config/global-constants')
    * features: [none]
  A diem-infallible 0.1.0 (workspace, path 'common/infallible')
    * features: [none]
  A diem-logger 0.1.0 (workspace, path 'common/logger')
    * features: [none]
  A diem-metrics-core 0.1.0 (workspace, path 'common/metrics-core')
    * features: [none]
  A diem-network-address 0.1.0 (workspace, path 'network/network-address')
    * features: default
  A diem-network-address-encryption 0.1.0 (workspace, path 'config/management/network-address-encryption')
    * features: [none]
  A diem-nibble 0.1.0 (workspace, path 'common/nibble')
    * features: default
  A diem-secure-net 0.1.0 (workspace, path 'secure/net')
    * features: [none]
  A diem-secure-push-metrics 0.1.0 (workspace, path 'secure/push-metrics')
    * features: [none]
  A diem-secure-storage 0.1.0 (workspace, path 'secure/storage')
    * features: [none]
  A diem-secure-time 0.1.0 (workspace, path 'secure/time')
    * features: [none]
  A diem-state-view 0.1.0 (workspace, path 'storage/state-view')
    * features: default
  A diem-temppath 0.1.0 (workspace, path 'common/temppath')
    * features: [none]
  A diem-types 0.1.0 (workspace, path 'types')
    * features: default
  A diem-vault-client 0.1.0 (workspace, path 'secure/storage/vault')
    * features: [none]
  R libra-config 0.1.0 (workspace, path 'config')
    * (old features: default)
  R libra-crypto 0.1.0 (workspace, path 'crypto/crypto')
    * (old features: curve25519-dalek, default, ed25519-dalek, fiat, x25519-dalek)
  R libra-github-client 0.1.0 (workspace, path 'secure/storage/github')
    * (old features: [none])
  R libra-global-constants 0.1.0 (workspace, path 'config/global-constants')
    * (old features: [none])
  R libra-infallible 0.1.0 (workspace, path 'common/infallible')
    * (old features: [none])
  R libra-logger 0.1.0 (workspace, path 'common/logger')
    * (old features: [none])
  R libra-metrics-core 0.1.0 (workspace, path 'common/metrics-core')
    * (old features: [none])
  R libra-network-address 0.1.0 (workspace, path 'network/network-address')
    * (old features: default)
  R libra-network-address-encryption 0.1.0 (workspace, path 'config/management/network-address-encryption')
    * (old features: [none])
  R libra-nibble 0.1.0 (workspace, path 'common/nibble')
    * (old features: default)
  R libra-secure-net 0.1.0 (workspace, path 'secure/net')
    * (old features: [none])
  R libra-secure-push-metrics 0.1.0 (workspace, path 'secure/push-metrics')
    * (old features: [none])
  R libra-secure-storage 0.1.0 (workspace, path 'secure/storage')
    * (old features: [none])
  R libra-secure-time 0.1.0 (workspace, path 'secure/time')
    * (old features: [none])
  R libra-state-view 0.1.0 (workspace, path 'storage/state-view')
    * (old features: default)
  R libra-temppath 0.1.0 (workspace, path 'common/temppath')
    * (old features: [none])
  R libra-types 0.1.0 (workspace, path 'types')
    * (old features: default)
  R libra-vault-client 0.1.0 (workspace, path 'secure/storage/vault')
    * (old features: [none])

host packages:
  A diem-crypto-derive 0.1.0 (workspace, path 'crypto/crypto-derive')
    * features: [none]
  A diem-log-derive 0.1.0 (workspace, path 'common/logger/derive')
    * features: [none]
  R libra-crypto-derive 0.1.0 (workspace, path 'crypto/crypto-derive')
    * (old features: [none])
  R libra-log-derive 0.1.0 (workspace, path 'common/logger/derive')
    * (old features: [none])

tzakian · 2020-12-07T17:12:26Z

/cancel

tzakian · 2020-12-07T17:13:20Z

/land
/priority = high
/priority high

Closes: diem#6798

libra-action · 2020-12-07T17:18:46Z

LSR dependency change summary:

target packages:
  A diem-config 0.1.0 (workspace, path 'config')
    * features: default
  A diem-crypto 0.1.0 (workspace, path 'crypto/crypto')
    * features: curve25519-dalek, default, ed25519-dalek, fiat, x25519-dalek
  A diem-github-client 0.1.0 (workspace, path 'secure/storage/github')
    * features: [none]
  A diem-global-constants 0.1.0 (workspace, path 'config/global-constants')
    * features: [none]
  A diem-infallible 0.1.0 (workspace, path 'common/infallible')
    * features: [none]
  A diem-logger 0.1.0 (workspace, path 'common/logger')
    * features: [none]
  A diem-metrics-core 0.1.0 (workspace, path 'common/metrics-core')
    * features: [none]
  A diem-network-address 0.1.0 (workspace, path 'network/network-address')
    * features: default
  A diem-network-address-encryption 0.1.0 (workspace, path 'config/management/network-address-encryption')
    * features: [none]
  A diem-nibble 0.1.0 (workspace, path 'common/nibble')
    * features: default
  A diem-secure-net 0.1.0 (workspace, path 'secure/net')
    * features: [none]
  A diem-secure-push-metrics 0.1.0 (workspace, path 'secure/push-metrics')
    * features: [none]
  A diem-secure-storage 0.1.0 (workspace, path 'secure/storage')
    * features: [none]
  A diem-secure-time 0.1.0 (workspace, path 'secure/time')
    * features: [none]
  A diem-state-view 0.1.0 (workspace, path 'storage/state-view')
    * features: default
  A diem-temppath 0.1.0 (workspace, path 'common/temppath')
    * features: [none]
  A diem-types 0.1.0 (workspace, path 'types')
    * features: default
  A diem-vault-client 0.1.0 (workspace, path 'secure/storage/vault')
    * features: [none]
  R libra-config 0.1.0 (workspace, path 'config')
    * (old features: default)
  R libra-crypto 0.1.0 (workspace, path 'crypto/crypto')
    * (old features: curve25519-dalek, default, ed25519-dalek, fiat, x25519-dalek)
  R libra-github-client 0.1.0 (workspace, path 'secure/storage/github')
    * (old features: [none])
  R libra-global-constants 0.1.0 (workspace, path 'config/global-constants')
    * (old features: [none])
  R libra-infallible 0.1.0 (workspace, path 'common/infallible')
    * (old features: [none])
  R libra-logger 0.1.0 (workspace, path 'common/logger')
    * (old features: [none])
  R libra-metrics-core 0.1.0 (workspace, path 'common/metrics-core')
    * (old features: [none])
  R libra-network-address 0.1.0 (workspace, path 'network/network-address')
    * (old features: default)
  R libra-network-address-encryption 0.1.0 (workspace, path 'config/management/network-address-encryption')
    * (old features: [none])
  R libra-nibble 0.1.0 (workspace, path 'common/nibble')
    * (old features: default)
  R libra-secure-net 0.1.0 (workspace, path 'secure/net')
    * (old features: [none])
  R libra-secure-push-metrics 0.1.0 (workspace, path 'secure/push-metrics')
    * (old features: [none])
  R libra-secure-storage 0.1.0 (workspace, path 'secure/storage')
    * (old features: [none])
  R libra-secure-time 0.1.0 (workspace, path 'secure/time')
    * (old features: [none])
  R libra-state-view 0.1.0 (workspace, path 'storage/state-view')
    * (old features: default)
  R libra-temppath 0.1.0 (workspace, path 'common/temppath')
    * (old features: [none])
  R libra-types 0.1.0 (workspace, path 'types')
    * (old features: default)
  R libra-vault-client 0.1.0 (workspace, path 'secure/storage/vault')
    * (old features: [none])

host packages:
  A diem-crypto-derive 0.1.0 (workspace, path 'crypto/crypto-derive')
    * features: [none]
  A diem-log-derive 0.1.0 (workspace, path 'common/logger/derive')
    * features: [none]
  R libra-crypto-derive 0.1.0 (workspace, path 'crypto/crypto-derive')
    * (old features: [none])
  R libra-log-derive 0.1.0 (workspace, path 'common/logger/derive')
    * (old features: [none])

libra-action · 2020-12-07T17:18:46Z

LEC dependency change summary:

target packages:
  A diem-config 0.1.0 (workspace, path 'config')
    * features: default
  A diem-crypto 0.1.0 (workspace, path 'crypto/crypto')
    * features: curve25519-dalek, default, ed25519-dalek, fiat, x25519-dalek
  A diem-github-client 0.1.0 (workspace, path 'secure/storage/github')
    * features: [none]
  A diem-global-constants 0.1.0 (workspace, path 'config/global-constants')
    * features: [none]
  A diem-infallible 0.1.0 (workspace, path 'common/infallible')
    * features: [none]
  A diem-logger 0.1.0 (workspace, path 'common/logger')
    * features: [none]
  A diem-metrics 0.1.0 (workspace, path 'common/metrics')
    * features: [none]
  A diem-metrics-core 0.1.0 (workspace, path 'common/metrics-core')
    * features: [none]
  A diem-network-address 0.1.0 (workspace, path 'network/network-address')
    * features: default
  A diem-network-address-encryption 0.1.0 (workspace, path 'config/management/network-address-encryption')
    * features: [none]
  A diem-nibble 0.1.0 (workspace, path 'common/nibble')
    * features: default
  A diem-secure-net 0.1.0 (workspace, path 'secure/net')
    * features: [none]
  A diem-secure-push-metrics 0.1.0 (workspace, path 'secure/push-metrics')
    * features: [none]
  A diem-secure-storage 0.1.0 (workspace, path 'secure/storage')
    * features: [none]
  A diem-secure-time 0.1.0 (workspace, path 'secure/time')
    * features: [none]
  A diem-state-view 0.1.0 (workspace, path 'storage/state-view')
    * features: default
  A diem-temppath 0.1.0 (workspace, path 'common/temppath')
    * features: [none]
  A diem-trace 0.1.0 (workspace, path 'common/trace')
    * features: [none]
  A diem-types 0.1.0 (workspace, path 'types')
    * features: default
  A diem-vault-client 0.1.0 (workspace, path 'secure/storage/vault')
    * features: [none]
  A diem-vm 0.1.0 (workspace, path 'language/diem-vm')
    * features: default
  R libra-config 0.1.0 (workspace, path 'config')
    * (old features: default)
  R libra-crypto 0.1.0 (workspace, path 'crypto/crypto')
    * (old features: curve25519-dalek, default, ed25519-dalek, fiat, x25519-dalek)
  R libra-github-client 0.1.0 (workspace, path 'secure/storage/github')
    * (old features: [none])
  R libra-global-constants 0.1.0 (workspace, path 'config/global-constants')
    * (old features: [none])
  R libra-infallible 0.1.0 (workspace, path 'common/infallible')
    * (old features: [none])
  R libra-logger 0.1.0 (workspace, path 'common/logger')
    * (old features: [none])
  R libra-metrics 0.1.0 (workspace, path 'common/metrics')
    * (old features: [none])
  R libra-metrics-core 0.1.0 (workspace, path 'common/metrics-core')
    * (old features: [none])
  R libra-network-address 0.1.0 (workspace, path 'network/network-address')
    * (old features: default)
  R libra-network-address-encryption 0.1.0 (workspace, path 'config/management/network-address-encryption')
    * (old features: [none])
  R libra-nibble 0.1.0 (workspace, path 'common/nibble')
    * (old features: default)
  R libra-secure-net 0.1.0 (workspace, path 'secure/net')
    * (old features: [none])
  R libra-secure-push-metrics 0.1.0 (workspace, path 'secure/push-metrics')
    * (old features: [none])
  R libra-secure-storage 0.1.0 (workspace, path 'secure/storage')
    * (old features: [none])
  R libra-secure-time 0.1.0 (workspace, path 'secure/time')
    * (old features: [none])
  R libra-state-view 0.1.0 (workspace, path 'storage/state-view')
    * (old features: default)
  R libra-temppath 0.1.0 (workspace, path 'common/temppath')
    * (old features: [none])
  R libra-trace 0.1.0 (workspace, path 'common/trace')
    * (old features: [none])
  R libra-types 0.1.0 (workspace, path 'types')
    * (old features: default)
  R libra-vault-client 0.1.0 (workspace, path 'secure/storage/vault')
    * (old features: [none])
  R libra-vm 0.1.0 (workspace, path 'language/libra-vm')
    * (old features: default)

host packages:
  A diem-crypto-derive 0.1.0 (workspace, path 'crypto/crypto-derive')
    * features: [none]
  A diem-log-derive 0.1.0 (workspace, path 'common/logger/derive')
    * features: [none]
  R libra-crypto-derive 0.1.0 (workspace, path 'crypto/crypto-derive')
    * (old features: [none])
  R libra-log-derive 0.1.0 (workspace, path 'common/logger/derive')
    * (old features: [none])

libra-action · 2020-12-07T17:18:47Z

release binaries dependency change summary:

target packages:
  A diem-genesis-tool 0.1.0 (initial, path 'config/management/genesis')
    * features: testing
  A diem-key-manager 0.1.0 (initial, path 'secure/key-manager')
    * features: [none]
  A diem-node 0.1.0 (initial, path 'diem-node')
    * features: default
  A diem-bitvec 0.1.0 (workspace, path 'common/bitvec')
    * features: [none]
  A diem-config 0.1.0 (workspace, path 'config')
    * features: default
  A diem-crypto 0.1.0 (workspace, path 'crypto/crypto')
    * features: curve25519-dalek, default, ed25519-dalek, fiat, x25519-dalek
  A diem-github-client 0.1.0 (workspace, path 'secure/storage/github')
    * features: [none]
  A diem-global-constants 0.1.0 (workspace, path 'config/global-constants')
    * features: [none]
  A diem-infallible 0.1.0 (workspace, path 'common/infallible')
    * features: [none]
  A diem-jellyfish-merkle 0.1.0 (workspace, path 'storage/jellyfish-merkle')
    * features: default
  A diem-json-rpc 0.1.0 (workspace, path 'json-rpc')
    * features: [none]
  A diem-json-rpc-types 0.1.0 (workspace, path 'json-rpc/types')
    * features: [none]
  A diem-logger 0.1.0 (workspace, path 'common/logger')
    * features: [none]
  A diem-management 0.1.0 (workspace, path 'config/management')
    * features: [none]
  A diem-mempool 0.1.0 (workspace, path 'mempool')
    * features: default
  A diem-metrics 0.1.0 (workspace, path 'common/metrics')
    * features: [none]
  A diem-metrics-core 0.1.0 (workspace, path 'common/metrics-core')
    * features: [none]
  A diem-network-address 0.1.0 (workspace, path 'network/network-address')
    * features: default
  A diem-network-address-encryption 0.1.0 (workspace, path 'config/management/network-address-encryption')
    * features: [none]
  A diem-nibble 0.1.0 (workspace, path 'common/nibble')
    * features: default
  A diem-secure-json-rpc 0.1.0 (workspace, path 'secure/json-rpc')
    * features: [none]
  A diem-secure-net 0.1.0 (workspace, path 'secure/net')
    * features: [none]
  A diem-secure-push-metrics 0.1.0 (workspace, path 'secure/push-metrics')
    * features: [none]
  A diem-secure-storage 0.1.0 (workspace, path 'secure/storage')
    * features: [none]
  A diem-secure-time 0.1.0 (workspace, path 'secure/time')
    * features: [none]
  A diem-state-view 0.1.0 (workspace, path 'storage/state-view')
    * features: default
  A diem-temppath 0.1.0 (workspace, path 'common/temppath')
    * features: [none]
  A diem-trace 0.1.0 (workspace, path 'common/trace')
    * features: [none]
  A diem-types 0.1.0 (workspace, path 'types')
    * features: default
  A diem-vault-client 0.1.0 (workspace, path 'secure/storage/vault')
    * features: [none]
  A diem-vm 0.1.0 (workspace, path 'language/diem-vm')
    * features: default
  A diemdb 0.1.0 (workspace, path 'storage/diemdb')
    * features: default
  R libra-genesis-tool 0.1.0 (initial, path 'config/management/genesis')
    * (old features: testing)
  R libra-key-manager 0.1.0 (initial, path 'secure/key-manager')
    * (old features: [none])
  R libra-node 0.1.0 (initial, path 'libra-node')
    * (old features: default)
  R libra-bitvec 0.1.0 (workspace, path 'common/bitvec')
    * (old features: [none])
  R libra-config 0.1.0 (workspace, path 'config')
    * (old features: default)
  R libra-crypto 0.1.0 (workspace, path 'crypto/crypto')
    * (old features: curve25519-dalek, default, ed25519-dalek, fiat, x25519-dalek)
  R libra-github-client 0.1.0 (workspace, path 'secure/storage/github')
    * (old features: [none])
  R libra-global-constants 0.1.0 (workspace, path 'config/global-constants')
    * (old features: [none])
  R libra-infallible 0.1.0 (workspace, path 'common/infallible')
    * (old features: [none])
  R libra-jellyfish-merkle 0.1.0 (workspace, path 'storage/jellyfish-merkle')
    * (old features: default)
  R libra-json-rpc 0.1.0 (workspace, path 'json-rpc')
    * (old features: [none])
  R libra-json-rpc-types 0.1.0 (workspace, path 'json-rpc/types')
    * (old features: [none])
  R libra-logger 0.1.0 (workspace, path 'common/logger')
    * (old features: [none])
  R libra-management 0.1.0 (workspace, path 'config/management')
    * (old features: [none])
  R libra-mempool 0.1.0 (workspace, path 'mempool')
    * (old features: default)
  R libra-metrics 0.1.0 (workspace, path 'common/metrics')
    * (old features: [none])
  R libra-metrics-core 0.1.0 (workspace, path 'common/metrics-core')
    * (old features: [none])
  R libra-network-address 0.1.0 (workspace, path 'network/network-address')
    * (old features: default)
  R libra-network-address-encryption 0.1.0 (workspace, path 'config/management/network-address-encryption')
    * (old features: [none])
  R libra-nibble 0.1.0 (workspace, path 'common/nibble')
    * (old features: default)
  R libra-secure-json-rpc 0.1.0 (workspace, path 'secure/json-rpc')
    * (old features: [none])
  R libra-secure-net 0.1.0 (workspace, path 'secure/net')
    * (old features: [none])
  R libra-secure-push-metrics 0.1.0 (workspace, path 'secure/push-metrics')
    * (old features: [none])
  R libra-secure-storage 0.1.0 (workspace, path 'secure/storage')
    * (old features: [none])
  R libra-secure-time 0.1.0 (workspace, path 'secure/time')
    * (old features: [none])
  R libra-state-view 0.1.0 (workspace, path 'storage/state-view')
    * (old features: default)
  R libra-temppath 0.1.0 (workspace, path 'common/temppath')
    * (old features: [none])
  R libra-trace 0.1.0 (workspace, path 'common/trace')
    * (old features: [none])
  R libra-types 0.1.0 (workspace, path 'types')
    * (old features: default)
  R libra-vault-client 0.1.0 (workspace, path 'secure/storage/vault')
    * (old features: [none])
  R libra-vm 0.1.0 (workspace, path 'language/libra-vm')
    * (old features: default)
  R libradb 0.1.0 (workspace, path 'storage/libradb')
    * (old features: default)

host packages:
  A diem-crypto-derive 0.1.0 (workspace, path 'crypto/crypto-derive')
    * features: [none]
  A diem-log-derive 0.1.0 (workspace, path 'common/logger/derive')
    * features: [none]
  R libra-crypto-derive 0.1.0 (workspace, path 'crypto/crypto-derive')
    * (old features: [none])
  R libra-log-derive 0.1.0 (workspace, path 'common/logger/derive')
    * (old features: [none])

MIRAI-bot · 2020-12-07T17:23:10Z

Hey hey!

It looks like #wannabe-land-blocking found some issues that are not yet land blocking, but will be in the future.
Please fix these:

click here to reveal them

warning: integer arithmetic detected
  --> language/testing-infra/e2e-tests/src/currencies.rs:38:5
   |
38 |     dr_sequence_number += 1;
   |     ^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#integer_arithmetic
warning: integer arithmetic detected

--> language/testing-infra/e2e-tests/src/currencies.rs:79:5

|

79 |     dr_sequence_number += 1;

|     ^^^^^^^^^^^^^^^^^^^^^^^

|

= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#integer_arithmetic
warning: integer arithmetic detected

--> language/testing-infra/e2e-tests/src/currencies.rs:115:5

|

115 |     dr_sequence_number + 1

|     ^^^^^^^^^^^^^^^^^^^^^^

|

= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#integer_arithmetic
warning: integer arithmetic detected

--> types/src/test_helpers/transaction_test_helpers.rs:26:27

|

26 |     let expiration_time = diem_infallible::duration_since_epoch().as_secs() + 10;

|                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

|

= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#integer_arithmetic
warning: integer arithmetic detected

--> types/src/test_helpers/transaction_test_helpers.rs:135:27

|

135 |     let expiration_time = diem_infallible::duration_since_epoch().as_secs() + 10; // 10 seconds from now.

|                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

|

= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#integer_arithmetic
warning: integer arithmetic detected

--> types/src/test_helpers/transaction_test_helpers.rs:156:27

|

156 |     let expiration_time = diem_infallible::duration_since_epoch().as_secs() + 10; // 10 seconds from now.

|                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

|

= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#integer_arithmetic
warning: integer arithmetic detected

--> types/src/test_helpers/transaction_test_helpers.rs:177:27

|

177 |     let expiration_time = diem_infallible::duration_since_epoch().as_secs() + 10; // 10 seconds from now.

|                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

|

= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#integer_arithmetic

MIRAI-bot · 2020-12-07T17:34:04Z

Hey hey!

It looks like #wannabe-land-blocking found some issues that are not yet land blocking, but will be in the future.
Please fix these:

click here to reveal them

warning: integer arithmetic detected
  --> language/testing-infra/e2e-tests/src/currencies.rs:38:5
   |
38 |     dr_sequence_number += 1;
   |     ^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#integer_arithmetic
warning: integer arithmetic detected

--> language/testing-infra/e2e-tests/src/currencies.rs:79:5

|

79 |     dr_sequence_number += 1;

|     ^^^^^^^^^^^^^^^^^^^^^^^

|

= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#integer_arithmetic
warning: integer arithmetic detected

--> language/testing-infra/e2e-tests/src/currencies.rs:115:5

|

115 |     dr_sequence_number + 1

|     ^^^^^^^^^^^^^^^^^^^^^^

|

= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#integer_arithmetic
warning: integer arithmetic detected

--> types/src/test_helpers/transaction_test_helpers.rs:26:27

|

26 |     let expiration_time = diem_infallible::duration_since_epoch().as_secs() + 10;

|                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

|

= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#integer_arithmetic
warning: integer arithmetic detected

--> types/src/test_helpers/transaction_test_helpers.rs:135:27

|

135 |     let expiration_time = diem_infallible::duration_since_epoch().as_secs() + 10; // 10 seconds from now.

|                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

|

= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#integer_arithmetic
warning: integer arithmetic detected

--> types/src/test_helpers/transaction_test_helpers.rs:156:27

|

156 |     let expiration_time = diem_infallible::duration_since_epoch().as_secs() + 10; // 10 seconds from now.

|                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

|

= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#integer_arithmetic
warning: integer arithmetic detected

--> types/src/test_helpers/transaction_test_helpers.rs:177:27

|

177 |     let expiration_time = diem_infallible::duration_since_epoch().as_secs() + 10; // 10 seconds from now.

|                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

|

= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#integer_arithmetic

github-actions · 2020-12-07T17:36:29Z

Cluster Test Result

all up : 934 TPS, 4844 ms latency, 6100 ms p99 latency, no expired txns
Logs: http://kibana.ct-1-k8s-testnet.aws.hlw3truzy4ls.com/app/kibana#/discover?_g=(time:(from:'2020-12-07T17:24:55Z',to:'2020-12-07T17:36:28Z'))
Dashboard: http://grafana.ct-1-k8s-testnet.aws.hlw3truzy4ls.com/d/2XqUIhnWz/performance?from=1607361895000&to=1607362588000
Validator 1 logs: http://kibana.ct-1-k8s-testnet.aws.hlw3truzy4ls.com/app/kibana#/discover?_g=(time:(from:'2020-12-07T17:24:55Z',to:'2020-12-07T17:36:28Z'))&_a=(columns:!(log),query:(language:kuery,query:'kubernetes.pod_name:"val-1"'),sort:!(!('@timestamp',desc)))

Repro cmd:

./scripts/cti --tag land_76576974 -E RUST_LOG=debug --report report.json --suite land_blocking

🎉 Land-blocking cluster test passed! 👌

MIRAI-bot · 2020-12-07T17:59:32Z

Hey hey!

It looks like #wannabe-land-blocking found some issues that are not yet land blocking, but will be in the future.
Please fix these:

click here to reveal them

warning: integer arithmetic detected
  --> language/testing-infra/e2e-tests/src/currencies.rs:38:5
   |
38 |     dr_sequence_number += 1;
   |     ^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#integer_arithmetic
warning: integer arithmetic detected

--> language/testing-infra/e2e-tests/src/currencies.rs:79:5

|

79 |     dr_sequence_number += 1;

|     ^^^^^^^^^^^^^^^^^^^^^^^

|

= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#integer_arithmetic
warning: integer arithmetic detected

--> language/testing-infra/e2e-tests/src/currencies.rs:115:5

|

115 |     dr_sequence_number + 1

|     ^^^^^^^^^^^^^^^^^^^^^^

|

= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#integer_arithmetic
warning: integer arithmetic detected

--> types/src/test_helpers/transaction_test_helpers.rs:26:27

|

26 |     let expiration_time = diem_infallible::duration_since_epoch().as_secs() + 10;

|                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

|

= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#integer_arithmetic
warning: integer arithmetic detected

--> types/src/test_helpers/transaction_test_helpers.rs:135:27

|

135 |     let expiration_time = diem_infallible::duration_since_epoch().as_secs() + 10; // 10 seconds from now.

|                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

|

= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#integer_arithmetic
warning: integer arithmetic detected

--> types/src/test_helpers/transaction_test_helpers.rs:156:27

|

156 |     let expiration_time = diem_infallible::duration_since_epoch().as_secs() + 10; // 10 seconds from now.

|                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

|

= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#integer_arithmetic
warning: integer arithmetic detected

--> types/src/test_helpers/transaction_test_helpers.rs:177:27

|

177 |     let expiration_time = diem_infallible::duration_since_epoch().as_secs() + 10; // 10 seconds from now.

|                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

|

= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#integer_arithmetic

phlip9 · 2020-12-07T22:40:04Z

crypto/crypto/src/hash.rs

 /// consists in this global prefix, concatenated with the specified
 /// serialization name of the struct.
-pub(crate) const LIBRA_HASH_PREFIX: &[u8] = b"LIBRA::";
+pub(crate) const DIEM_HASH_PREFIX: &[u8] = b"DIEM::";


Are we still making hard backwards incompatible breaking changes? This is one of them...

Yeah, trying to do it all at once.

tzakian requested review from xli, davidiw, mgorven, aching, dariorussi-zz, JoshLind, sausagee and sherry-x December 3, 2020 18:54

bors-libra added this to In Review in bors Dec 3, 2020

bmwill reviewed Dec 3, 2020

View reviewed changes

Cargo.toml Outdated Show resolved Hide resolved

tzakian force-pushed the rename_all_the_things branch 2 times, most recently from 5def085 to a37da80 Compare December 3, 2020 19:21

mgorven reviewed Dec 3, 2020

View reviewed changes

CONTRIBUTING.md Outdated Show resolved Hide resolved

tzakian force-pushed the rename_all_the_things branch from c80b5e4 to f0c5cd2 Compare December 4, 2020 02:35

sausagee reviewed Dec 4, 2020

View reviewed changes

docker/compose/public_full_node/docker-compose.yaml Outdated Show resolved Hide resolved

docker/compose/validator-testnet/docker-compose.yaml Outdated Show resolved Hide resolved

docker/compose/mint/docker-compose.yaml Outdated Show resolved Hide resolved

README.md Show resolved Hide resolved

tzakian force-pushed the rename_all_the_things branch from f0c5cd2 to 13d05ca Compare December 4, 2020 17:42

tzakian commented Dec 4, 2020

View reviewed changes

tzakian force-pushed the rename_all_the_things branch from 13d05ca to ced9527 Compare December 4, 2020 18:05

mgorven reviewed Dec 4, 2020

View reviewed changes

tzakian force-pushed the rename_all_the_things branch from ced9527 to b4d380b Compare December 4, 2020 19:15

aching reviewed Dec 4, 2020

View reviewed changes

CONTRIBUTING.md Outdated Show resolved Hide resolved

config/README.md Outdated Show resolved Hide resolved

tzakian force-pushed the rename_all_the_things branch 3 times, most recently from c077b7b to d03eaea Compare December 4, 2020 20:39

tzakian marked this pull request as ready for review December 4, 2020 20:51

tzakian requested review from kchalkias, ma2bd, thefallentree and valerini as code owners December 4, 2020 20:51

bors-libra moved this from Testing to In Review in bors Dec 7, 2020

bors-libra moved this from In Review to Queued in bors Dec 7, 2020

bors-libra pushed a commit that referenced this pull request Dec 7, 2020

[Rename] Rename all occurences of "Libra" to "Diem"

dc0cc9d

Closes: #6798

bors-libra moved this from Queued to Testing in bors Dec 7, 2020

bors-libra moved this from Testing to In Review in bors Dec 7, 2020

tzakian force-pushed the rename_all_the_things branch from 30172cd to 831eb10 Compare December 7, 2020 17:13

bors-libra moved this from In Review to Queued in bors Dec 7, 2020

[Rename] Rename all occurences of "Libra" to "Diem"

7657697

Closes: diem#6798

bors-libra moved this from Queued to Testing in bors Dec 7, 2020

bors-libra force-pushed the rename_all_the_things branch from 831eb10 to 7657697 Compare December 7, 2020 17:41

bors-libra removed this from Testing in bors Dec 7, 2020

bors-libra closed this in 7657697 Dec 7, 2020

bors-libra merged commit 7657697 into diem:master Dec 7, 2020

phlip9 reviewed Dec 7, 2020

View reviewed changes

aching added the breaking Any changes that will require restarting the testnet label Dec 7, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rename all the things from libra to diem #6798

Rename all the things from libra to diem #6798

tzakian commented Dec 3, 2020 •

edited

sherry-x commented Dec 3, 2020

tzakian Dec 4, 2020

JoshLind Dec 5, 2020

tzakian Dec 5, 2020

JoshLind Dec 5, 2020

aching left a comment

tzakian commented Dec 7, 2020

bors-libra commented Dec 7, 2020

tzakian commented Dec 7, 2020

libra-action commented Dec 7, 2020

libra-action commented Dec 7, 2020

libra-action commented Dec 7, 2020

tzakian commented Dec 7, 2020

tzakian commented Dec 7, 2020

libra-action commented Dec 7, 2020

libra-action commented Dec 7, 2020

libra-action commented Dec 7, 2020

MIRAI-bot commented Dec 7, 2020

MIRAI-bot commented Dec 7, 2020

github-actions bot commented Dec 7, 2020

MIRAI-bot commented Dec 7, 2020

phlip9 Dec 7, 2020

aching Dec 7, 2020

Rename all the things from libra to diem #6798

Rename all the things from libra to diem #6798

Conversation

tzakian commented Dec 3, 2020 • edited

sherry-x commented Dec 3, 2020

tzakian Dec 4, 2020

Choose a reason for hiding this comment

JoshLind Dec 5, 2020

Choose a reason for hiding this comment

tzakian Dec 5, 2020

Choose a reason for hiding this comment

JoshLind Dec 5, 2020

Choose a reason for hiding this comment

aching left a comment

Choose a reason for hiding this comment

tzakian commented Dec 7, 2020

bors-libra commented Dec 7, 2020

tzakian commented Dec 7, 2020

libra-action commented Dec 7, 2020

libra-action commented Dec 7, 2020

libra-action commented Dec 7, 2020

tzakian commented Dec 7, 2020

tzakian commented Dec 7, 2020

libra-action commented Dec 7, 2020

libra-action commented Dec 7, 2020

libra-action commented Dec 7, 2020

MIRAI-bot commented Dec 7, 2020

MIRAI-bot commented Dec 7, 2020

github-actions bot commented Dec 7, 2020

MIRAI-bot commented Dec 7, 2020

phlip9 Dec 7, 2020

Choose a reason for hiding this comment

aching Dec 7, 2020

Choose a reason for hiding this comment

tzakian commented Dec 3, 2020 •

edited