Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

op metrics refactoring/cleanup #12109

Closed
kitsonk opened this issue Sep 16, 2021 · 2 comments
Closed

op metrics refactoring/cleanup #12109

kitsonk opened this issue Sep 16, 2021 · 2 comments
Assignees
@AaronO
Labels
feat new feature (which has been agreed to/accepted) maybe 2.0 a potential feature for Deno 2.0 that needs further discussion
Projects
Deno CLI 2.0
Milestone
2.0

Comments

@kitsonk
Copy link
Contributor

kitsonk commented Sep 16, 2021

The op metrics are a problem, they contain a lot of cruft that is no longer applicable. It needs a good refactor for 2.0.
@kitsonk kitsonk added feat new feature (which has been agreed to/accepted) maybe 2.0 a potential feature for Deno 2.0 that needs further discussion labels Sep 16, 2021
@kitsonk kitsonk mentioned this issue Sep 17, 2021
Closed
17 tasks
@kitsonk kitsonk added this to the 2.0.0 milestone Sep 17, 2021
@kitsonk kitsonk added this to To do in Deno CLI 2.0 Sep 17, 2021
@bartlomieju
Copy link
Member

I really want to get Deno.Metrics.ops stabilized (https://doc.deno.land/builtin/unstable#Deno.Metrics) for 2.0. I don't see any blockers for it, besides committing to the Deno.Metrics.OpMetrics type.

This come up in #12142

@ry ry moved this from To do to Scoped/Designed in Deno CLI 2.0 Sep 28, 2021
@bartlomieju
Copy link
Member

This has been mostly done, during numerous refactors that @AaronO and @littledivy did in the past months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AaronO AaronO

Labels
feat new feature (which has been agreed to/accepted) maybe 2.0 a potential feature for Deno 2.0 that needs further discussion
Projects
No open projects
Deno CLI 2.0
Scoped/Designed
Milestone
2.0
Development

No branches or pull requests
3 participants
@AaronO @kitsonk @bartlomieju