Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New testing style in Rust crate #1866

Closed
Tracked by #2525
sundy-li opened this issue Sep 17, 2021 · 4 comments · Fixed by #2724 or #3295
Closed
Tracked by #2525

New testing style in Rust crate #1866

sundy-li opened this issue Sep 17, 2021 · 4 comments · Fixed by #2724 or #3295
Assignees
@PsiACE
Labels
C-feature Category: feature v0.6 v0.6 version

Comments

@sundy-li
Copy link
Member

Summary

Description for this feature.

Databend used Golang testing style currently, but there is a more rustacean testing style of cargo, refer to https://matklad.github.io/2021/02/27/delete-cargo-integration-tests.html
@sundy-li sundy-li added C-feature Category: feature discuss labels Sep 17, 2021
@jorgecarleitao
Copy link

I moved all tests in arrow2 to a separate location and it made it much faster to write new tests, as we do not need to re-compile the crate. It also made it clear when a certain API was only "public" within the module (and not to users of the crate). Highly recommend!

@PsiACE
Copy link
Member

PsiACE commented Sep 17, 2021

I prefer the Rust style.

@BohuTANG
Copy link
Member

Thank you @jorgecarleitao , your information is important, Databend test is getting slower and will continue on.
@PsiACE It's time to start doing it, go Rust style.

@PsiACE
Copy link
Member

PsiACE commented Sep 17, 2021

/assginme

@PsiACE PsiACE self-assigned this Sep 17, 2021
drmingdrmer added a commit to drmingdrmer/databend that referenced this issue Sep 22, 2021
@drmingdrmer
[metasrv] refactor: organized integration test in the rust-crate styl…
5bafe51 
…e: move flight api test into metasrv/tests/

- According to datafuselabs#1866
  https://matklad.github.io/2021/02/27/delete-cargo-integration-tests.html
@drmingdrmer drmingdrmer mentioned this issue Sep 22, 2021
Merged
drmingdrmer added a commit to drmingdrmer/databend that referenced this issue Sep 22, 2021
@drmingdrmer
[metasrv] refactor: organized integration test in the rust-crate styl…
4d84d5e 
…e: move flight api test into metasrv/tests/

- According to datafuselabs#1866
  https://matklad.github.io/2021/02/27/delete-cargo-integration-tests.html
drmingdrmer added a commit to drmingdrmer/databend that referenced this issue Sep 22, 2021
@drmingdrmer
[metasrv] refactor: organized integration test in the rust-crate styl…
3966769 
…e: move flight api test into metasrv/tests/

- According to datafuselabs#1866
  https://matklad.github.io/2021/02/27/delete-cargo-integration-tests.html
@BohuTANG BohuTANG removed the discuss label Oct 16, 2021
@PsiACE PsiACE added the v0.6 v0.6 version label Oct 31, 2021
@BohuTANG BohuTANG mentioned this issue Nov 1, 2021
Closed
13 tasks
This was referenced Nov 1, 2021
Merged
Merged
Merged
Merged
Merged
@PsiACE PsiACE mentioned this issue Nov 9, 2021
Merged
@PsiACE PsiACE reopened this Nov 9, 2021
This was referenced Nov 11, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Nov 15, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
This was referenced Dec 3, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PsiACE PsiACE

Labels
C-feature Category: feature v0.6 v0.6 version
Projects
None yet
Milestone
No milestone
4 participants
@BohuTANG @jorgecarleitao @sundy-li @PsiACE