New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improvement] consider move out management/namespace/local_kv_store.rs #1855
Comments
For the user create interface:
From the query layer, we don't know how to choose to use the
There is a bit confusion with this api exposed directly, we would like a wrapper like this(or Others, get one KVApi implement by the config):
@drmingdrmer @dantengsky Would love to hear your thoughts :) |
hi, for
|
Since kv store channel needs authentication information( token or tls configs), it may not be convenient to embed those in a URI. |
will it be more friendly to use if we change
to
? |
It smells well.
I agree with @dantengsky . For use in unit test, a URI would be expressive and convenient. |
@drmingdrmer @dantengsky |
For usage in unit test, it should be something like this? 🤔 : let t = tempfile::tempdir().expect("create temp dir to sled db");
init_temp_sled_db(t);
let api = LocalKVStore::new_temp().await?;
let mut mgr = NamespaceMgr::new(api);
let res = mgr
.add_node(
tenant_id.to_string(),
namespace_id.to_string(),
node.clone(),
)
.await?; @BohuTANG |
Yes, exactly. BTW The type local or remote can be decided by the query from the config, something like a URI. |
I like the idea of choosing an impl by querying a config entry. In order to implement this, shall In literal, it seems like that |
RemoteFactory build them may be better?
Another question is that, the query config have It should be
|
#1876 Resolved |
Is this issue all right to close yet? |
Summary
For now, local_kv_store is used by namespace and in
management/namespace
,user
mod also need it:store-api/src/impls/local_kv_store.rs
? cc @drmingdrmerasync fn auth_user(&mut self, password: impl AsRef<[u8]>) -> bool
to UserMgrApi trait (@BohuTANG )The text was updated successfully, but these errors were encountered: