Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-1639:Remove session_api.rs #1649

Merged
merged 2 commits into from Aug 29, 2021
Merged

Conversation

jyz0309
Copy link
Contributor

@jyz0309 jyz0309 commented Aug 29, 2021

I hereby agree to the terms of the CLA available at: https://datafuse.rs/policies/cla/

Summary

Remove common/store-api/session_api.rs

Changelog

  • Improvement

Related Issues

Fixes #1639

Test Plan

Unit Tests

Stateless Tests

jyz0309 added 2 commits August 29, 2021 17:32
Signed-off-by: jyz0309 <a1kaid@foxmail.com>
Signed-off-by: jyz0309 <a1kaid@foxmail.com>
@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@databend-bot
Copy link
Member

Hello @jyz0309, 🎉 Thank you for opening the pull request! 🎉
Your pull request state is not in Draft, please add Reviewers or Re-request review again!
FuseQuery: @BohuTANG @sundy-li @zhang2014
FuseStore: @drmingdrmer @dantengsky
Or visit datafuse roadmap for some clues.

@jyz0309 jyz0309 changed the title Remove session_api.rs ISSUE-1639:Remove session_api.rs Aug 29, 2021
Copy link
Member

@BohuTANG BohuTANG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you @jyz0309

@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2021

Codecov Report

Merging #1649 (5bfb9fe) into master (fd1c308) will increase coverage by 0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1649     +/-   ##
========================================
  Coverage      72%     73%             
========================================
  Files         521     543     +22     
  Lines       31533   33125   +1592     
========================================
+ Hits        22997   24439   +1442     
- Misses       8536    8686    +150     
Impacted Files Coverage Δ
common/flights/src/store_do_action.rs 92% <ø> (+2%) ⬆️
store/src/executor/action_handler.rs 59% <ø> (ø)
...ry/src/datasources/remote/store_client_provider.rs 0% <0%> (-100%) ⬇️
query/src/datasources/remote/remote_factory.rs 43% <0%> (-48%) ⬇️
...mmon/functions/src/aggregates/aggregator_common.rs 61% <0%> (-20%) ⬇️
common/datavalues/src/arrays/ops/cast.rs 57% <0%> (-18%) ⬇️
common/datavalues/src/types/data_type_coercion.rs 67% <0%> (-13%) ⬇️
query/src/common/hash_table_entity.rs 66% <0%> (-10%) ⬇️
common/datavalues/src/data_value_ops.rs 40% <0%> (-8%) ⬇️
common/datablocks/src/data_block_test.rs 93% <0%> (-7%) ⬇️
... and 150 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd1c308...5bfb9fe. Read the comment docs.

@jyz0309
Copy link
Contributor Author

jyz0309 commented Aug 29, 2021

It seems that the failure is not caused by me. How to rerun it? @BohuTANG

@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

20 similar comments
@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

13 similar comments
@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

@PsiACE PsiACE merged commit 2380745 into datafuselabs:master Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[improvement] remove unused common/store-api/session_api.rs
5 participants