New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISSUE-1639:Remove session_api.rs #1649
Conversation
Signed-off-by: jyz0309 <a1kaid@foxmail.com>
Signed-off-by: jyz0309 <a1kaid@foxmail.com>
Thanks for the contribution! Please review the labels and make any necessary changes. |
Hello @jyz0309, 🎉 Thank you for opening the pull request! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you @jyz0309
Codecov Report
@@ Coverage Diff @@
## master #1649 +/- ##
========================================
Coverage 72% 73%
========================================
Files 521 543 +22
Lines 31533 33125 +1592
========================================
+ Hits 22997 24439 +1442
- Misses 8536 8686 +150
Continue to review full report at Codecov.
|
It seems that the failure is not caused by me. How to rerun it? @BohuTANG |
CI Passed |
20 similar comments
CI Passed |
CI Passed |
CI Passed |
CI Passed |
CI Passed |
CI Passed |
CI Passed |
CI Passed |
CI Passed |
CI Passed |
CI Passed |
CI Passed |
CI Passed |
CI Passed |
CI Passed |
CI Passed |
CI Passed |
CI Passed |
CI Passed |
CI Passed |
CI Passed |
13 similar comments
CI Passed |
CI Passed |
CI Passed |
CI Passed |
CI Passed |
CI Passed |
CI Passed |
CI Passed |
CI Passed |
CI Passed |
CI Passed |
CI Passed |
CI Passed |
I hereby agree to the terms of the CLA available at: https://datafuse.rs/policies/cla/
Summary
Remove
common/store-api/session_api.rs
Changelog
Related Issues
Fixes #1639
Test Plan
Unit Tests
Stateless Tests