Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default config should use foreground color instead of white #78

Closed
jxerome opened this issue Oct 28, 2020 · 10 comments
Closed

Default config should use foreground color instead of white #78

jxerome opened this issue Oct 28, 2020 · 10 comments
Assignees

Comments

@jxerome
Copy link

jxerome commented Oct 28, 2020

Hello,

I tried procs.
But got a bad first time experience due to the default config that uses BrightWhite instead of Foreground color.

Here is a capture:
Capture d’écran 2020-10-28 à 18 22 24

BrightWhite may be fancier for people with black background, but don't just work for others.

Thank you

@dalance dalance self-assigned this Oct 28, 2020
@dalance
Copy link
Owner

dalance commented Nov 4, 2020

Thank you for your request.
I think there are the following choices:

  • change from BrightWhite to Foreground color by default
  • set background color to black by default ( and add background color configuration )

I think the second choice is better because the same view can be provided to any background color.
What do you think?

@fwkz
Copy link

fwkz commented Nov 4, 2020

An ad-hoc workaround would be disabling colors using procs -c disable

@jxerome
Copy link
Author

jxerome commented Nov 8, 2020

Well, I suppose using foreground would be the most user-friendly choice. Maybe using Bold color would keep BrightWhite for most people with dark themes.

Think about a tool that would change your background to white because that's the developer preference. I'm not sure you would like it. Especially setting a background different from terminal background is usually just ugly as it looks as if you highlighted the text.

The best scenario would be able to detect if the terminal uses a light or dark theme and automatically apply the correct color setting, but I don't know if it's only possible.

@dalance
Copy link
Owner

dalance commented Nov 9, 2020

OK. I'll add auto detection of background color.
Some tools ( ex. vim/emacs ) detect the color on some terminals.

Now I'm working on https://github.com/dalance/termbg.

@jasikpark
Copy link

If there was at least a simple switch for light mode as well, that'd be swell.

Especially similar to bat:

# .zshrc
alias bat="bat --theme=\$(defaults read -globalDomain AppleInterfaceSty  │ le &> /dev/null && echo default || echo GitHub)"

@Th3Whit3Wolf
Copy link

Somewhat off topic but being able to choose a config would be nice too. I use a daemon to change colorschemes at sunrise and sunset on linux. CLI programs that support this are great because I can place a script in ~/.local/bin/ with the same name of the file that chooses the conf based on time.

dalance added a commit that referenced this issue Jan 28, 2021
@dalance
Copy link
Owner

dalance commented Jan 28, 2021

Sorry it took so long.
I added automatic theme detection, and released v0.11.0.

By default, dark/light theme is selected automatically.
If detection failed, you can specify theme by --theme option.

image
image

@dalance
Copy link
Owner

dalance commented Jan 28, 2021

If you customized color by config file, some changes are required.
For example,

-style = "Black"
+style = "Black|White"

Please see for the detailed information:
https://github.com/dalance/procs#color-list

@ztlevi
Copy link

ztlevi commented Jan 30, 2021

@dalance Hi, I tried the latest procs but the command column is still in grey color.

image

image

Would you mind update that part?

Thank you!

@dalance
Copy link
Owner

dalance commented Jan 30, 2021

I forgot to apply light theme to default config.
I fixed it, and released v0.11.3.

@dalance dalance closed this as completed May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants