Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add use-full-config flag to enable full config without creating a file #152

Closed
wants to merge 1 commit into from

Conversation

twardakm
Copy link

@twardakm twardakm commented Jun 9, 2021

Sometimes it is usefull to use procs with full config without creating
separate config file (for example if we ask someone to collect some
data for us).

It also modifies CONFIG_ALL static to the same values as are in
config/large.toml.

Sometimes it is usefull to use procs with full config without creating
separate config file (for example if we ask someone to collect some
data for us).

It also modifies CONFIG_ALL static to the same values as are in
config/large.toml.
@twardakm
Copy link
Author

twardakm commented Jun 9, 2021

I started to use procs on embedded devices to gather some CPU / RSS data while debugging, but I struggled all the time with creating config file, just to have RSS value.

I think it would be beneficial to be able to run procs without this burden, and a flag is in my opinion a nice solution here.

@dalance dalance self-assigned this Jun 10, 2021
@dalance
Copy link
Owner

dalance commented Jun 22, 2021

Thank you for your request.
I think this is good idea, but there is some considerations.

  • The CONFIG_ALL is for test of all columns. You should add another static like CONFIG_LARGE.
  • It may be useful that some embedded configs can be selected through like --use-config default, --use-config large.

@twardakm
Copy link
Author

Thanks for your suggestions, they make perfect sense. I will change my merge request soon.

@pleshevskiy
Copy link

It may be useful that some embedded configs can be selected through like --use-config default, --use-config large.

I totally agree! I wanted to create an issue, that would be useful if we could use different configs for different situations.

dalance added a commit that referenced this pull request Mar 2, 2023
@dalance
Copy link
Owner

dalance commented Mar 3, 2023

I added --use-config and built-in configs ( default and large ) which are the same as config/*.toml.
So I'll close this PR.

@dalance dalance closed this Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants