Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Valid JSON Output #2

Closed
weslambert opened this issue Sep 3, 2021 · 2 comments
Closed

Valid JSON Output #2

weslambert opened this issue Sep 3, 2021 · 2 comments
Assignees
@fscc-jamesd
Labels
bug Something isn't working

Comments

@weslambert
Copy link

Great work on this! I really appreciate all the work that went into it!

While the individual objects contained within the JSON output are considered valid JSON, it seems like when they are concatenated together in the results file, they are not separated (by comma ,), and/or considered as an array of objects (with open/closing bracket []), so the results can't be picked up by tools that parse JSON without additional work. If needed, I can follow up with a PR as I get time.

Additionally, it would be nice to consider allowing for JSON output to stdout, so a file would not need to be written to disk, but other tools could easily parse the data returned.
@fscc-jamesd fscc-jamesd self-assigned this Sep 3, 2021
@fscc-jamesd fscc-jamesd added the bug Something isn't working label Sep 3, 2021
fscc-alexkornitzer added a commit that referenced this issue Sep 3, 2021
@fscc-alexkornitzer
fix: json output was incorrect #2
58a0d29 
In order to save RAM json output was a bit complicated and had some
errors as raised. At the cost of RAM, for now we have simplified the
process and just output the data at the end of the functions.
@fscc-alexkornitzer
Copy link
Contributor

The above should fix the json issue, I think we will then create a new issue to track the stdout support for piping purposes as an enhancement.

@weslambert
Copy link
Author

weslambert commented Sep 3, 2021 •
edited

The above should fix the json issue, I think we will then create a new issue to track the stdout support for piping purposes as an enhancement.

Sounds good, thanks! I've opened #8 to track JSON to stdout.

@weslambert weslambert mentioned this issue Sep 3, 2021
Closed
fscc-jamesd added a commit that referenced this issue Sep 3, 2021
@fscc-jamesd
Merge pull request #7 from countercept/fix/json
c50d273 
fix: json output was incorrect #2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fscc-jamesd fscc-jamesd

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@weslambert @fscc-alexkornitzer @fscc-jamesd