Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nix dependency #9

Merged
merged 1 commit into from Aug 17, 2021
Merged

Conversation

Furisto
Copy link
Member

@Furisto Furisto commented Aug 16, 2021

Now that the oci spec is decoupled from youki, we should not expose nix types as part of the api.

@codecov-commenter
Copy link

Codecov Report

Merging #9 (a8d6c70) into main (88a9cb7) will increase coverage by 0.31%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
+ Coverage   25.00%   25.31%   +0.31%     
==========================================
  Files           5        5              
  Lines         556      549       -7     
  Branches      315      314       -1     
==========================================
  Hits          139      139              
+ Misses        158      151       -7     
  Partials      259      259              

Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saschagrunert
Copy link
Member

@Furisto can you please rebase? 🙃

@Furisto
Copy link
Member Author

Furisto commented Aug 17, 2021

@saschagrunert Done

@saschagrunert saschagrunert merged commit 68a0b1b into containers:main Aug 17, 2021
@chenyukang chenyukang mentioned this pull request Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants