Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OCI distribution spec #37

Merged
merged 1 commit into from Aug 25, 2021

Conversation

saschagrunert
Copy link
Member

Closes #21

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@codecov-commenter
Copy link

Codecov Report

Merging #37 (d11e312) into main (31b5488) will increase coverage by 1.14%.
The diff coverage is 44.26%.

@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
+ Coverage   19.04%   20.19%   +1.14%     
==========================================
  Files          13       17       +4     
  Lines         961     1040      +79     
  Branches      524      552      +28     
==========================================
+ Hits          183      210      +27     
- Misses        387      411      +24     
- Partials      391      419      +28     

Copy link
Member

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to separate directories by version, like specs-go?

@@ -5,6 +5,8 @@
#[macro_use]
mod macros;

#[cfg(feature = "distribution")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@saschagrunert
Copy link
Member Author

Do we need to separate directories by version, like specs-go?

Hm, yeah I think so. I can follow-up on that.

@utam0k
Copy link
Member

utam0k commented Aug 25, 2021

Hm, yeah I think so. I can follow-up on that.

I'll leave this to you.

@saschagrunert saschagrunert merged commit 400313b into containers:main Aug 25, 2021
@saschagrunert saschagrunert deleted the distribution-spec branch August 25, 2021 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add distribution spec
3 participants