Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup CI #3

Closed
6 tasks done
saschagrunert opened this issue Aug 16, 2021 · 11 comments
Closed
6 tasks done

Setup CI #3

saschagrunert opened this issue Aug 16, 2021 · 11 comments

Comments

@saschagrunert
Copy link
Member

saschagrunert commented Aug 16, 2021

I think we should set up a basic CI pipeline for the crate, which does:

  • build
  • unit test including code coverage
  • clippy lint
  • rustfmt
  • build docs and push to gh-pages branch
  • crates.io publishing
@utam0k
Copy link
Member

utam0k commented Aug 16, 2021

What about the release flow to crates.io?
https://crates.io/

@saschagrunert
Copy link
Member Author

What about the release flow to crates.io?
https://crates.io/

Which crate name do we wanna choose?

@utam0k
Copy link
Member

utam0k commented Aug 16, 2021

It seems that oci already several crates. oci_spec is the best, however, I think _ and - might be misunderstood, so I think oci_spec_rs is fine. What do you think?
https://crates.io/search?page=1&per_page=10&q=oci

It seems that _ is preferred over -.
rust-lang/api-guidelines#29 (comment)

@saschagrunert
Copy link
Member Author

saschagrunert commented Aug 16, 2021

oci_spec already exists: https://crates.io/crates/oci_spec

I'm also in favor of oci_spec_rs.

@utam0k how about reaching out to the maintainer of oci_spec to join efforts? This way we could re-use the crate name.

@utam0k
Copy link
Member

utam0k commented Aug 16, 2021

@saschagrunert I am very much in favor of cooperation. I'm sure the knowledge of this author will be put to great use.
However, I can't really imagine how we can cooperate. What kind of cooperation do you imagine?

@saschagrunert
Copy link
Member Author

@saschagrunert I am very much in favor of cooperation. I'm sure the knowledge of this author will be put to great use.
However, I can't really imagine how we can cooperate. What kind of cooperation do you imagine?

It looks like that the initial crate got no update since 2 years. For example we would also need the image (and maybe artifact) spec beside the runtime spec.

So asking directly @smiyaguchi, do you see a way that we can reuse the crate name and merge both positive sides of the repositories?

@utam0k
Copy link
Member

utam0k commented Aug 16, 2021

The image spec could certainly be integrated 👍

@smiyaguchi
Copy link

@saschagrunert Thank you for contacting me.

do you see a way that we can reuse the crate name and merge both positive sides of the repositories?

I have never repurposed a crate before, so I don't know if it would work, but would you like me to add the owner to the oci-spec crate?

I think this is a great project and I would be happy to help in any way I can.
If you have any other ideas, please let me know.

@saschagrunert
Copy link
Member Author

@saschagrunert Thank you for contacting me.

do you see a way that we can reuse the crate name and merge both positive sides of the repositories?

I have never repurposed a crate before, so I don't know if it would work, but would you like me to add the owner to the oci-spec crate?

This would be wonderful, thank you so much! ❤️ (please add @utam0k, too)

I think this is a great project and I would be happy to help in any way I can.
If you have any other ideas, please let me know.

Thank you! Yeah the integration of other parts of the spec is definitely a goal. Feel free to mention if you notice any gaps between your implementation and this one. We're happy to take the advantage of both.

@utam0k
Copy link
Member

utam0k commented Aug 18, 2021

Thank you for responding. Let's work together 🤝

@saschagrunert
Copy link
Member Author

Closing since the crate name point has been resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants