Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make credentials optional if using on local network #2

Open
oleggtro opened this issue Aug 29, 2021 · 4 comments
Open

Make credentials optional if using on local network #2

oleggtro opened this issue Aug 29, 2021 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@oleggtro
Copy link
Contributor

afaik it shoult be possible to use the bot with spotify webapi tokens -> it should be possible to implement oauth and offer the bot to more than one user without giving away login credentials
@oleggtro
Copy link
Contributor Author

any comment on this? @codetheweb

@codetheweb
Copy link
Owner

codetheweb commented Aug 29, 2021 •
edited

librespot doesn't (and won't) support OAuth.

Making the credentials optional in the case of using it on your local network seems like a good feature to add though.

@codetheweb
Copy link
Owner

I'll keep this open for now and reword it slightly.

@codetheweb codetheweb reopened this Sep 13, 2021
@codetheweb codetheweb changed the title oauth Make credentials optional if using on local network Sep 13, 2021
@codetheweb codetheweb added enhancement New feature or request good first issue Good for newcomers labels Sep 13, 2021
@oleggtro
Copy link
Contributor Author

I think I may use this as one of my hacktober contribs

@oleggtro oleggtro mentioned this issue Oct 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@codetheweb @oleggtro