New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize for size #6
Conversation
ack i left my "format on save" on for the sandbox...but all i did was take out the optimizations in there, since they don't actually change anything in a workspace |
454d6bf
to
cf9a261
Compare
@caass -- out of curiosity, what size impact did you notice this had on the |
i didn't check, but now i'm thinking it's better to leave it in there on rust-sandbox since it's more likely we'll be running wasm-pack build commands in there as a single crate, and not as a member of a workspace. although. maybe it'll still treat it like a member of a workspace |
we should always check 👍 and, you're right, this crate will far more often be build as a dep inside some end-user's project (using wasm-pack or something else in the future) vs. a workspace member. |
so i have found out it gets treated as a workspace member regardless of where you compile it from. so i dont think we need the profile to stay in rust-sandbox, but it doesn't really matter too much. before optimizations (compiled in release mode): after optimizations (release mode): 10% savings on size |
sweet -- thank you! |
will merge as-is, but i'll include a revert on the Cargo.toml indentation in a future PR. |
feat: move headers into own module
No description provided.