Thanks @fkettelhoit! this is great, and nice catch with the route issue. I'll give this and your other PR a review ASAP.

@fkettelhoit -

testing this on branch merge/pr-34, I observe this panic:

panicked at 'failed to register Options route for /async pattern: Conflict { with: "/async" }', ~/workers-rs/worker/src/router.rs:271:18

Mind taking a look?

I haven't deployed the sandbox worker yet, but shouldn't this be the expected behavior? In line 235 the worker uses an on_async, which will match all methods, including OPTIONS and thus clash with the options_async in line 347.

(Btw I also noticed that the with_status method in this branch uses a Result<Self> signature again, despite your previous commit. Sorry about the signature change btw, you are right that the Self return type makes more sense for mapping responses.)

I haven't deployed the sandbox worker yet, but shouldn't this be the expected behavior? In line 235 the worker uses an on_async, which will match all methods, including OPTIONS and thus clash with the options_async in line 347.

Ah, yes! thank you. Definitely working as expected 😆

(Btw I also noticed that the with_status method in this branch uses a Result signature again, despite your previous commit. Sorry about the signature change btw, you are right that the Self return type makes more sense for mapping responses.)

Yea I need to rebase this. Thanks! No worries about the signature change.. it's really the right thing to do so we can catch invalid codes.. Do you think it's worth the trade-off? My concern is that it's pretty unlikely that the end-user will defensively attempt to check this error, since Response is generally at the very end of the block... very open to input on it though!

I was initially a bit torn myself, but I agree that choosing Self is the better trade-off. Situations where handling the error instead of panicking makes a difference should be pretty rare and Result<Self> is definitely much more inconvenient to use.

Ok, cool. Thank you for the feedback. I'll leave it as-is then and we can reconsider later on!