Make libworker::Error public and non-exhaustive
#19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilslice
force-pushed
the
jnelson/error
branch
from
81cfe93
to
deda285
Compare
|
This is a good idea, but I don't think it's actually complete.. could you try to deploy and test the running
Based on the code in /// # use libworker::{Error, Response, Router};
/// let mut router = Router::new();
/// let result: Result<(), Error> = router.post_async("/my_json_api", |mut req, env, _params| async move {
/// let input = match req.json().await {
/// Ok(j) => j,
/// Err(Error::BadEncoding) => return Response::error("POST body must be JSON", 400),
/// Err(other_err) => return Err(other_err),
/// };
/// Response::ok("{}")
/// }); |
Making it public allows users to handle errors themselves. Making it non-exhaustive allows us to add more error variants in the future without needing a breaking change.
nilslice
force-pushed
the
jnelson/error
branch
from
deda285
to
17c440d
Compare
|
Closing this as it was done in another branch. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making it public allows users to handle errors themselves.
Making it non-exhaustive allows us to add more error variants in the future without needing a breaking change.
Fixes #11