Don't require async functions passed to *_async handlers to have a 'static lifetime
#16
Conversation
…'static lifetime
I found this while trying to avoid copying in this example from the README:
```
router.on_async("/proxy_request/*url", |_req, _env, params| {
// Must copy the parameters into the heap here for lifetime purposes
let url = params
.get("url")
.unwrap()
.strip_prefix('/')
.unwrap()
.to_string();
async move { Fetch::Url(&url).send().await }
})?;
```
Unfortunately, that particular example still doesn't compile, but this now allows other borrows.
|
Thanks, @jyn514 - gonna use this PR as the first for Actions / checks, so it may be a few hours before I merge but all looks good so far. |
|
Tested manually as we're waiting for some internal things before we can enable Actions... LGTM. thanks! |
|
Just for posterity, I've changed the fn to use a hashmap for the parsed route params coming from the |
Ah, ok - I think that should mean you no longer need to allocate in the example in the readme, then :) |
|
Correct - it's been updated! Thanks. |
I found this while trying to avoid copying in this example from the README:
Unfortunately, that particular example still doesn't compile, but this now allows other borrows.