Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preview and command-line argument support for default chooser #947

Closed
terror opened this issue Aug 13, 2021 · 3 comments
Closed

Add preview and command-line argument support for default chooser #947

terror opened this issue Aug 13, 2021 · 3 comments

Comments

@terror
Copy link
Contributor

terror commented Aug 13, 2021

When --chose is invoked without specifying a chooser, it uses fzf with recipe names present in the projects justfile without a preview window for currently highlighted recipes. If a recipe is selected it invokes just with that recipe name without prompting the user to pass in any command-line arguments.

Consider adding a preview window to display the recipes contents during the search in addition to being able to pass in command-line arguments to recipes that take them.

Here's a rough idea for how this may look like:

asciicast

@casey
Copy link
Owner

casey commented Aug 14, 2021

This is a great idea. I think this should be added once we switch to skim (#939) as the default chooser. It'll be easier to add features to the choosing command if we know for sure what chooser we're invoking.

This will require some tweaks to how the command works. Currently, the choose subcommand can only take recipes, to take arguments, it'll have to invoke the run command.

@Qeole
Copy link
Contributor

Qeole commented Dec 11, 2023

Looks like this was implemented in #1539?

@casey
Copy link
Owner

casey commented Dec 11, 2023

Nice, yup, this can be closed.

@casey casey closed this as completed Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants