Add fnv to stdx #38
Merged
Add fnv to stdx #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brson
reviewed
Jun 13, 2017
README.md
Outdated
| @@ -13,6 +13,7 @@ Current revision: `stdx` 0.118.0-rc, for Rust 1.18, June 8, 2017. | |||
| | Date and time | [`chrono = "0.3.1"`] | [📖][d-chrono] | | |||
| | Command-line argument parsing | [`clap = "2.24.2"`] | [📖][d-clap] | | |||
| | Error handling | [`error-chain = "0.10.0"`] | [📖][d-error-chain] | | |||
| | FNV hash function | [`fnv = "1.0.3"`] | [📖][d-fnv] | | |||
There was a problem hiding this comment.
Since most people won't know what "FNV" is, how about we say "Fast (FN) hashing".
brson
reviewed
Jun 13, 2017
examples/fnv.rs
Outdated
| map.remove(&(2)); | ||
| println!("The length of HashMap is {}.", map.len()); | ||
| println!("The first element is {}.", map.get(&(1)).unwrap()); | ||
| } |
There was a problem hiding this comment.
The inside of this function needs to be intended one level, and likewise in the markdown.
brson
reviewed
Jun 13, 2017
README.md
Outdated
| @@ -1140,6 +1175,7 @@ copyright is owned by its contributors. | |||
| [d-clap]: https://docs.rs/clap/2.24.2/clap/ | |||
| [d-error-chain]: https://docs.rs/error-chain/0.8.1/error_chain/ | |||
| [d-flate2]: https://docs.rs/flate2/0.2.19/flate2/ | |||
| [d-fnv]: https://doc.servo.org/fnv/ | |||
There was a problem hiding this comment.
Please make this link "https://docs.rs/fnv/1.0.3/fnv/". All docs on this page link to docs.rs
|
Ping @alisha17 |
alisha17
force-pushed
the
hashmap
branch
2 times, most recently
from
f15dbb3
to
da0a93d
Compare
|
Thanks @alisha17! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fnv crate example using FNV HashMap
Fix to issue #34