Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove flate2 and hyper. They don't meet the 'just-work's criteria. #3

Closed
wants to merge 1 commit into from

Conversation

brson
Copy link
Owner

@brson brson commented Jul 6, 2015

No description provided.

@DanielKeep
Copy link
Contributor

I'm a bit on the fence about it. As it stands, any HTTP library won't "just work" due to having to handle HTTPS and/or HTTP/2.0. That's not going to make people want HTTP support any less.

Then again, if you do want stdx to be something you can just blindly drop into a project... well, if they want hyper, they can always add it manually...

...except that doesn't solve the problem of people even knowing about hyper and that they should use it.

My gut tells me to keep it, and crates like it, if only to document that they are crates that you should consider using. Heck, maybe stdx could go a bit further and include a hint on what it takes to run them. Something like this added to the description:

Optional. hyper is optional because it is large, and requires: a C compiler, and the libopenssl library and headers.

That could give users a quick, rough indication as to how hard it will be to get the crate working (maybe they already have those things!).

@reem
Copy link

reem commented Jul 7, 2015

I agree with @DanielKeep, though I am of course biased.

@leoyvens
Copy link

leoyvens commented Jul 7, 2015

It's very positive to give one HTTP library a quasi-official status, keeping hyper optional in stdx is an important blessing.

@brson
Copy link
Owner Author

brson commented Jul 7, 2015

OK, it seems clear that recommending a crate for important functionality is important, even if it doesn't yet warrant turning on by default.

@brson brson closed this Jul 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants