Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add itertools to stdx #15

Closed
LLBlumire opened this issue Jan 23, 2017 · 8 comments
Closed

Add itertools to stdx #15

LLBlumire opened this issue Jan 23, 2017 · 8 comments

Comments

@LLBlumire
Copy link

Seems like a core part of what people commonly use for functionality with rusts iterators and I believe it meets all the criteria listed

@brson
Copy link
Owner

brson commented Jan 24, 2017

I actually just removed itertools! I agree it fits the criteria though.

The reason I removed it is because I was writing up examples and didn't see an obvious example for itertools that sold me on the crate being essential. And since I don't think I've ever used itertools myself it seemed like a good candidate to cut - keeping the list concise is important to me.

What's the thing you always reach to itertools for?

@LLBlumire
Copy link
Author

step, combinations, and cartesian_product are my most used.

@mackwic
Copy link

mackwic commented Jan 25, 2017

my personal favorite are, in order, .sorted(), .unique(), and .group_by() (eventually lazy). These are all not-so-frequent operations, but still common enough in my opinion to justify the presence of itertools in stdx.

@jswrenn
Copy link

jswrenn commented Feb 6, 2017

I use group_by frequently for splitting input streams, and I just used tuple_windows for an implementation of bigram language models. The combination of Itertools and Rayon feels like having superpowers!

@Keruspe
Copy link

Keruspe commented Feb 8, 2017

.join() is really nice to have too

@iqualfragile
Copy link

yeah, i too feel like itertools is a must have.
if you are programming in a more procedural, less functional style, though, you might never feel any need for them.

@brson
Copy link
Owner

brson commented Jun 8, 2017

Yeah, ok. It is quite popular and battle tested, and does fill some gaps.

See https://github.com/brson/stdx/blob/master/CONTRIBUTING.md for details on how to add a crate.

Use a simple example based one or some of the above mentioned features.

@brson brson changed the title Add itertools? Add itertools to stdx Jun 8, 2017
@brson
Copy link
Owner

brson commented Jul 8, 2017

Done

@brson brson closed this as completed Jul 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants