Remove redundant .enumerate() calls and fix cargo bench compilation #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@homu r+ |
|
📌 Commit 4a21001 has been approved by |
homu
added a commit
that referenced
this pull request
Mar 29, 2016
Remove redundant .enumerate() calls and fix cargo bench compilation I've refactured and fixed some trivial things while reading the code. `cargo bench` compiles but panics in runtime, I think it should be easy to fix but it looks like benches are deprecated.
|
💥 Test timed out |
|
@homu retry |
homu
added a commit
that referenced
this pull request
Mar 29, 2016
Remove redundant .enumerate() calls and fix cargo bench compilation I've refactured and fixed some trivial things while reading the code. `cargo bench` compiles but panics in runtime, I think it should be easy to fix but it looks like benches are deprecated.
|
💥 Test timed out |
|
@homu retry |
homu
added a commit
that referenced
this pull request
Mar 30, 2016
Remove redundant .enumerate() calls and fix cargo bench compilation I've refactured and fixed some trivial things while reading the code. `cargo bench` compiles but panics in runtime, I think it should be easy to fix but it looks like benches are deprecated.
Looks like benchmarks are superseded by examples/benchmarks.rs and should be removed altogether, but while they are here they should at least compile cleanly. Well, now benches compile but panic on tensor dimension mismatch.
alexandermorozov
force-pushed
the
pr-cleanup
branch
from
4a21001
to
af19728
Compare
|
I've rebased this branch on master, hope this will help to alleviate Homu suffering. |
|
Thanks @alexandermorozov 👍 Let's see if Homu feels better now |
|
@homu r+ |
|
📌 Commit af19728 has been approved by |
|
⚡ Test exempted - status |
homu
added a commit
that referenced
this pull request
Mar 30, 2016
Remove redundant .enumerate() calls and fix cargo bench compilation I've refactured and fixed some trivial things while reading the code. `cargo bench` compiles but panics in runtime, I think it should be easy to fix but it looks like benches are deprecated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've refactured and fixed some trivial things while reading the code.
cargo benchcompiles but panics in runtime, I think it should be easy to fix but it looks like benches are deprecated.