Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo: crucial from curcial #79

Closed
wants to merge 1 commit into from

Conversation

palerdot
Copy link
Contributor

Changed typo from word curcial to crucial

@GitCop
Copy link

GitCop commented Mar 10, 2016

There were the following issues with your Pull Request

  • Commit: a5537c7
    • Commits must be in the following format: %{type}/%{scope}: %{description}

Guidelines are available at https://github.com/autumnai/leaf/blob/develop/CONTRIBUTING.md#git-commit-guidelines


This message was auto-generated by https://gitcop.com

@palerdot
Copy link
Contributor Author

@GitCop I couldn't find the guidelines in the mentioned url

@hobofan
Copy link
Member

hobofan commented Mar 11, 2016

@palerdot Thanks for the contribution! 👍
The correct link is this one: https://github.com/autumnai/leaf/blob/master/CONTRIBUTING.md#git-commit-guidelines

A fitting commit message for your commit would be docs/readme: crucial from curcial. The body of the commit message can stay the same.

@palerdot
Copy link
Contributor Author

Thanks. will do from now on.

@hobofan
Copy link
Member

hobofan commented Mar 11, 2016

Could you please also amend the commit message of this PR? 😉

Changed typo from word curcial to crucial
@palerdot
Copy link
Contributor Author

Amended. Was that Ok ?

@hobofan
Copy link
Member

hobofan commented Mar 11, 2016

Yes the commit message looks good now! :)

Due to some reasons Travis CI doesn't run the tests, but I think that's something I'll have to fix on our side.

@hobofan
Copy link
Member

hobofan commented Mar 11, 2016

Oh, damn, sorry for not noticing earlier. You fixed the problem in the gh-pages branch. However the gh-pages branch just contains documentation that will be regenerated after every push to master. So if I would merge the PR right now the change would disapear very soon.

The actual origin of the generated documentation would be here:
https://github.com/autumnai/leaf/blob/master/src/lib.rs#L59

@palerdot
Copy link
Contributor Author

I have given another pull request to master branch with the required commit format.
#83

@hobofan hobofan closed this Mar 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants