This repository has been archived by the owner on Jul 23, 2019. It is now read-only.
Buffer Selection Clipping #132
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathansobo
reviewed
Sep 18, 2018
| @@ -271,11 +271,11 @@ impl BufferView { | |||
| } | |||
|
|
|||
| pub fn set_cursor_position(&mut self, position: Point, autoscroll: bool) { | |||
| let clipped_point = self.buffer.borrow().clip_point(position); | |||
There was a problem hiding this comment.
Would you be cool just shadowing the original name position?
There was a problem hiding this comment.
And what test coverage should be added?
|
Thanks for diving in on this. Cool that you saw a TODO and took it on. To merge this, we'll need some basic test coverage as well however. |
This was referenced Apr 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clip_pointfunction in xray_core/src/buffer.rs