Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata modification #13

Closed
arctic-hen7 opened this issue Sep 17, 2021 · 1 comment
Closed

Metadata modification #13

arctic-hen7 opened this issue Sep 17, 2021 · 1 comment
Assignees
Labels
C-enhancement Category: enhancement
Milestone

Comments

@arctic-hen7
Copy link
Member

Right now, modifying the <head> in Perseus is pretty painful, and it needs to be done directly with web_sys. Especially in light of #2, Perseus should support a new property on a Template<G> that creates a Sycamore template for the document head. That should then be rendered to a string and interpolated directly into the head after any existing elements there.

This allows the user greater flexibility, and also allows the definition of universal properties on the <head>, which will be delimited from ones that are added with interpolation by a delimiter comment injected on the server-side.

@arctic-hen7 arctic-hen7 added the C-enhancement Category: enhancement label Sep 17, 2021
@arctic-hen7 arctic-hen7 added this to the v0.2.0 milestone Sep 17, 2021
@arctic-hen7 arctic-hen7 self-assigned this Sep 17, 2021
@arctic-hen7
Copy link
Member Author

This is now fully functional! However, right now there's still a glitch until the new head is injected, which is frankly disgusting. That will be fixed with #2 as part of the changes to the initial load system, which will involve server-side head injection (with a slight lag between title transitions as is typical of and unavoidable for pseudo-SPAs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: enhancement
Projects
None yet
Development

No branches or pull requests

1 participant