New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Progress bar "overlapping" track length #887
Comments
I'm seeing this as well. It appears that this has occurred due to an upgrade in the version of tui-rs from version 0.14.0 -> 0.16.0 (1ef37e7). I just tested downgrading back to 0.14.0 and the text is properly inverted when overtaken by the gauge bar. I think we ought to open an issue in tui-rs about this (if one does not already exist) and then maybe roll back the version until it gets fixed, unless we need 0.16.0 for some feature. |
I opened an issue on the tui-rs repo (fdehau/tui-rs#538) describing the regression. As a stop gap measure for spotify-tui, instead of reverting to an earlier version of tui-rs, we can simply ignore the user's configured progress bar label color until this regression gets fixed. Essentially, we can change src/ui/mod.rs:1052 from Style::default().fg(app.user_config.theme.playbar_progress_text), to be Style::default(), // .fg(app.user_config.theme.playbar_progress_text), --- To be added back in when fdehau/tui-rs#538 is resolved instead. This will make the label default to the progress bar foreground color and it will be properly inverted when the progress overtakes the label. |
I've noticed since I've updated the track length indicator no longer changes its color when intercepting the progress bar. I used the word overlapping in the title to try to explain it.
The text was updated successfully, but these errors were encountered: