Enable github workflow for snaps. #295

hurricanehrndz · 2020-02-13T15:23:42Z

Please add secrets to repo before accepting pull request. See email. If you have any question please fee free to contact me via email.

Rigellute

Sorry for the delay.

Thank you for doing this! I've added the secrets.

Just one comment about whether we want to run the snap script on every push to every branch or only master or only when a release tag is created?

Rigellute · 2020-02-17T10:33:58Z

.github/workflows/snap.yml

@@ -0,0 +1,68 @@
+name: snap
+
+on: [push]


Should we only push to snap from the master branch? Could do something like this?

Suggested change

on: [push]

on:

push:

branches:

- master

Or we could deploy only when a release tag is pushed? (the same way continous deployment is currently configured)

Suggested change

on: [push]

on:

push:

tags:

- "v*.*.*"

Sorry for the delay.

Thank you for doing this! I've added the secrets.

Just one comment about whether we want to run the snap script on every push to every branch or only master or only when a release tag is created?

Good question. I would run on every commit that leads to a release. That way we are warned when changes break snap builds. The workflow only pushes on tags. So if master is the only branch that ever gets released, I would run the workflow on every push to master.

Rigellute

Got you 👍

Thanks again

Rigellute · 2020-02-19T17:40:38Z

 User should be logged in
##[error]Process completed with exit code 1.
Run snapcraft whoami
  snapcraft whoami
  shell: /bin/bash -e {0}
/ not root-owned 501:50
##[error]Process completed with exit code 1.

After merging it fails with the above error. Any ideas on how to fix?

hurricanehrndz · 2020-02-19T18:01:32Z

This could be because the secret were copied and pasted incorrectly or were not named appropriately.

…

On Wed, Feb 19, 2020 at 10:40 AM Alexander Keliris ***@***.***> wrote: User should be logged in ##[error]Process completed with exit code 1. Run snapcraft whoami snapcraft whoami shell: /bin/bash -e {0} / not root-owned 501:50 ##[error]Process completed with exit code 1. After merging it fails with the above error. Any ideas on how to fix? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#295?email_source=notifications&email_token=ABMJBTNQ4CO6Y5BYQZ65ND3RDVVJNA5CNFSM4KUU45P2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMIX2EI#issuecomment-588348689>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABMJBTP7424RWYB6VCJE46TRDVVJNANCNFSM4KUU45PQ> .

-- Regards, Carlos Hernandez

hurricanehrndz · 2020-02-19T18:09:16Z

The snapcraft secret should be snapcraft_login, as per the line below. echo "${{ secrets.snapcraft_login }}" > "$snapcraft_creds"

…

On Wed, Feb 19, 2020 at 10:40 AM Alexander Keliris ***@***.***> wrote: User should be logged in ##[error]Process completed with exit code 1. Run snapcraft whoami snapcraft whoami shell: /bin/bash -e {0} / not root-owned 501:50 ##[error]Process completed with exit code 1. After merging it fails with the above error. Any ideas on how to fix? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#295?email_source=notifications&email_token=ABMJBTNQ4CO6Y5BYQZ65ND3RDVVJNA5CNFSM4KUU45P2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMIX2EI#issuecomment-588348689>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABMJBTP7424RWYB6VCJE46TRDVVJNANCNFSM4KUU45PQ> .

-- Regards, Carlos Hernandez

Rigellute · 2020-02-20T09:27:39Z

@hurricanehrndz I corrected one of the secrets (was previously named snapcraft_creds and changed to snapcraft_login).

However, looks like it is still failing 🤔 https://github.com/Rigellute/spotify-tui/runs/457296832?check_suite_focus=true

To confirm, the files you sent me are saved as follows

snapcraft.cfg saved as snapcraft_login
credentials saved as lp_creds

hurricanehrndz · 2020-02-20T12:44:43Z

@Rigellute ,

I re-exported the login information, and email it to you. Do you have snapcraft installed? If you do you should be to test the command from any directory with the login info emailed to you. Just run the following:

mkdir .snapcraft
cp snapcraft-login .snapcraft/snapcraft.cfg
snapcraft whoami

Rigellute · 2020-02-20T14:50:06Z

Have debugged and fixed the snap workflow. Turns out there were a few other problems not related to login info.

See the commits here if you're interested 268348e

hurricanehrndz · 2020-02-20T15:04:28Z

Alexander, Awesome work. The original pull request also works. I am certain it is a small piece of information I probably overlooked. I was hoping to get arm64 builds enabled. Please see here for proof: https://github.com/hurricanehrndz/spotify-tui/runs/457707733?check_suite_focus=true

…

On Thu., Feb. 20, 2020, 7:50 a.m. Alexander Keliris, < ***@***.***> wrote: Have debugged and fixed the snap workflow. Turns out there were a few other problems not related to login info. See the commits here if you're interested 268348e <268348e> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#295?email_source=notifications&email_token=ABMJBTKKJRDVED7JWTPSZ7LRD2KB7A5CNFSM4KUU45P2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMOMNAI#issuecomment-589088385>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABMJBTNHBUNHOMV6CSRRFELRD2KB7ANCNFSM4KUU45PQ> .

hurricanehrndz · 2020-02-20T15:15:29Z

If you are interested in getting the remote builds working, perhaps you can grant me maintainer rights long enough to fix and debug. Just a thought.

…

On Thu., Feb. 20, 2020, 7:50 a.m. Alexander Keliris, < ***@***.***> wrote: Have debugged and fixed the snap workflow. Turns out there were a few other problems not related to login info. See the commits here if you're interested 268348e <268348e> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#295?email_source=notifications&email_token=ABMJBTKKJRDVED7JWTPSZ7LRD2KB7A5CNFSM4KUU45P2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMOMNAI#issuecomment-589088385>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABMJBTNHBUNHOMV6CSRRFELRD2KB7ANCNFSM4KUU45PQ> .

hurricanehrndz · 2020-02-20T15:33:34Z

The reason remote build didn't work with the commit before <https://github.com/Rigellute/spotify-tui/runs/457933133?check_suite_focus=true> is because snapcraft in docker is version 3.8 and snapcraft version in snap is 3.9

…

On Thu, Feb 20, 2020 at 7:50 AM Alexander Keliris ***@***.***> wrote: Have debugged and fixed the snap workflow. Turns out there were a few other problems not related to login info. See the commits here if you're interested 268348e <268348e> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#295?email_source=notifications&email_token=ABMJBTKKJRDVED7JWTPSZ7LRD2KB7A5CNFSM4KUU45P2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMOMNAI#issuecomment-589088385>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABMJBTNHBUNHOMV6CSRRFELRD2KB7ANCNFSM4KUU45PQ> .

-- Regards, Carlos Hernandez

Rigellute · 2020-02-24T19:18:33Z

Hi @hurricanehrndz, I just cut a new release (v0.15.0) and encountered another issue with the snap workflow (see here https://github.com/Rigellute/spotify-tui/runs/465367238?check_suite_focus=true)

Error this time is

The store was unable to accept this snap.
binary_sha3_384: A file with this exact same content has already been uploaded

hurricanehrndz · 2020-02-25T04:59:27Z

I will promote the build that matches the release hash to beta for now, and I will look into a solution.

…

On Mon., Feb. 24, 2020, 12:18 p.m. Alexander Keliris, < ***@***.***> wrote: Hi @hurricanehrndz <https://github.com/hurricanehrndz>, I just cut a new release (v0.15.0) and encountered another issue with the snap workflow (see here https://github.com/Rigellute/spotify-tui/runs/465367238?check_suite_focus=true ) Error this time is The store was unable to accept this snap. binary_sha3_384: A file with this exact same content has already been uploaded — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#295?email_source=notifications&email_token=ABMJBTJ33GZBV3ATCGGUHD3REQMQVA5CNFSM4KUU45P2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMZFTWA#issuecomment-590502360>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABMJBTJMWNSGH6EXVDXT74TREQMQVANCNFSM4KUU45PQ> .

Rigellute · 2020-02-25T08:44:56Z

Nice one @hurricanehrndz, thanks so much for your help

hurricanehrndz · 2020-02-25T14:42:30Z

So I touched base with @popey, because I noticed that he is still pushing SPT and he walked me through how he is doing the snap maintenance. Anyhow, I'm confident that we do not need the action for now. Sorry for all the added work, it has been a blast working with you.

…

On Tue, Feb 25, 2020 at 1:44 AM Alexander Keliris ***@***.***> wrote: Nice one @hurricanehrndz <https://github.com/hurricanehrndz>, thanks so much for your help — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#295?email_source=notifications&email_token=ABMJBTPZ2CF5A4FDTOLVYALRETLATA5CNFSM4KUU45P2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEM3CJSQ#issuecomment-590750922>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABMJBTIDZ7ELZ7GNYZKQ3BTRETLATANCNFSM4KUU45PQ> .

-- Regards, Carlos Hernandez

Rigellute · 2020-02-25T16:47:11Z

No problem at all! And thank you.

Is this to say we should remove workflows/snap.yml?

Carlos Hernandez added 2 commits February 13, 2020 05:35

Rename snap to spt-temp

7c5f2e6

Add snap workflow

4546a7a

hurricanehrndz mentioned this pull request Feb 13, 2020

Update snap release Spotifyd/spotifyd#296

Closed

Rigellute reviewed Feb 17, 2020

View reviewed changes

Rigellute approved these changes Feb 19, 2020

View reviewed changes

Rigellute merged commit de7e29c into Rigellute:master Feb 19, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable github workflow for snaps. #295

Enable github workflow for snaps. #295

hurricanehrndz commented Feb 13, 2020

Rigellute left a comment

Rigellute Feb 17, 2020

hurricanehrndz Feb 19, 2020 •

edited

Rigellute left a comment

Rigellute commented Feb 19, 2020

hurricanehrndz commented Feb 19, 2020 via email •

edited

hurricanehrndz commented Feb 19, 2020 via email

Rigellute commented Feb 20, 2020

hurricanehrndz commented Feb 20, 2020 •

edited

Rigellute commented Feb 20, 2020

hurricanehrndz commented Feb 20, 2020 via email

hurricanehrndz commented Feb 20, 2020 via email

hurricanehrndz commented Feb 20, 2020 via email

Rigellute commented Feb 24, 2020

hurricanehrndz commented Feb 25, 2020 via email

Rigellute commented Feb 25, 2020

hurricanehrndz commented Feb 25, 2020 via email

Rigellute commented Feb 25, 2020

Enable github workflow for snaps. #295

Enable github workflow for snaps. #295

Conversation

hurricanehrndz commented Feb 13, 2020

Rigellute left a comment

Choose a reason for hiding this comment

Rigellute Feb 17, 2020

Choose a reason for hiding this comment

hurricanehrndz Feb 19, 2020 • edited

Choose a reason for hiding this comment

Rigellute left a comment

Choose a reason for hiding this comment

Rigellute commented Feb 19, 2020

hurricanehrndz commented Feb 19, 2020 via email • edited

hurricanehrndz commented Feb 19, 2020 via email

Rigellute commented Feb 20, 2020

hurricanehrndz commented Feb 20, 2020 • edited

Rigellute commented Feb 20, 2020

hurricanehrndz commented Feb 20, 2020 via email

hurricanehrndz commented Feb 20, 2020 via email

hurricanehrndz commented Feb 20, 2020 via email

Rigellute commented Feb 24, 2020

hurricanehrndz commented Feb 25, 2020 via email

Rigellute commented Feb 25, 2020

hurricanehrndz commented Feb 25, 2020 via email

Rigellute commented Feb 25, 2020

hurricanehrndz Feb 19, 2020 •

edited

hurricanehrndz commented Feb 19, 2020 via email •

edited

hurricanehrndz commented Feb 20, 2020 •

edited