I appreciate your work, but why would you want to remove the srv resolution? it is needed to join the vast majority of big server (e g. hypixel)

why would you want to remove the srv resolution?

Upps I thought it was a normal dns lookup where it got the ip's. but I now see it can also get ports.
So the solution I made would not function if they are not using default minecraft port.
I now see it can be a problem.

FIY. mc.hypixel.net seems to function properly.

Yea, so just revert your changes and only use the default port if the ip is numerical and no port was provided (or if the srv lookup fails) OR as an alternative you could first try the result of the srv lookup, then the provided port (if there is one) and at the or the default port, the second approach would be more complete although a bit harder to implement

I made a new commit, that keeps srv
not sure if we should remove the regex crate.
rust std has a ip parser.

   if let Err(_) = std::net::IpAddr::from_str(&addres) {
     ...
   }
   
   same almost
   
  if !IPADDRESS_PATTERN.is_match(&addres) {
    ...
  }
  

I made a new commit, that keeps srv
not sure if we should remove the regex crate.
rust std has a ip parser.

   if let Err(_) = std::net::IpAddr::from_str(&addres) {
     ...
   }
   
   same almost
   
  if !IPADDRESS_PATTERN.is_match(&addres) {
    ...
  }
  

If you are able to drop it without dropping any functionality that would be great. Are you sure rust can check if somthing is a domain or an ip tho?

yes I am sure

it is define like this.

enum IpAddr {
ipV4
ipV6
}

So you are also sure it that it doesn't automatically resolve the ip behind the domain?

So you are also sure it that it doesn't automatically resolve the ip behind the domain?
Here is the for IpAddr
https://doc.rust-lang.org/std/net/enum.IpAddr.html

Yes I tripped checked the code and also run some Manuel test with the server browser.

Can you rebase? then i'll merge this

Okay, can you rebase once again? then i'll merge it lol

This pr it is rebased on the lastest commit on master ca6e8e2 ?

There are merge conflicts @kepet19

Fixed! @terrarier2111

Fixed! @terrarier2111

I'll wait for the ci and as i have no access to a computer in like 10 minutes until i get home i'll merge it once i got home.

Okay, i am home now, could you resolve the merge conflicts? its the last time now, i promise

it is running again
no problem!