Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Flatpak #118

Merged
merged 7 commits into from Sep 8, 2021
Merged

Conversation

TheEvilSkeleton
Copy link
Contributor

No description provided.

@PureTryOut
Copy link
Collaborator

I was hoping it was possible to make a cargo subcommand? Or maybe even automatically run it when cargo run or cargo build is being ran.

@TheEvilSkeleton
Copy link
Contributor Author

Doesn't that defeat the purpose of reproducible builds? If we run the Python command everytime we try to build it, it will fetch all latest versions, which would make it irreproducible. In that case we can enable network support during build time if you wish.

@PureTryOut
Copy link
Collaborator

Ok so maybe not by default, but a separate cargo subcommand would still be nice (if possible) to ease generation of the right stuff.

@TheEvilSkeleton
Copy link
Contributor Author

TheEvilSkeleton commented Sep 8, 2021

@PureTryOut is this what you were talking about? TheEvilSkeleton@1ebd1e7

FYI: I tested it locally and it worked.

@TheEvilSkeleton TheEvilSkeleton changed the title Add flatpak-builder-tools submodule Improve Flatpak Sep 8, 2021
@TheEvilSkeleton TheEvilSkeleton force-pushed the flatpak/submodule branch 2 times, most recently from 58ffab5 to 238c2ee Compare September 8, 2021 01:25
@PureTryOut
Copy link
Collaborator

Not quite, although this is getting close. The script looks good, nice work so far.

I meant it'd be great if I could just run a cargo update-dependencies (for example).

However this scripts works well enough for me already that I'll merge it as is. We can do a cargo subcommand later.

@PureTryOut PureTryOut merged commit 17a73aa into Lea-fish:main Sep 8, 2021
@TheEvilSkeleton TheEvilSkeleton deleted the flatpak/submodule branch September 8, 2021 14:48
@TheEvilSkeleton
Copy link
Contributor Author

I meant it'd be great if I could just run a cargo update-dependencies (for example).

Hmm... I don't know much about cargo so sadly I cannot really help.

@iMonZ
Copy link
Contributor

iMonZ commented Sep 10, 2021

Thanks @TheEvilSkeleton this project really needed this PR.
But why aren't you using 21.08 freedesktop: flatpak/flatpak-github-actions@47e4de4
?

EDIT: the rust extension was somehow removed. I don't know why and how a workaround is possible.
https://gitlab.com/freedesktop-sdk/freedesktop-sdk/-/issues/1020

@TheEvilSkeleton
Copy link
Contributor Author

But why aren't you using 21.08 freedesktop: bilelmoussaoui/flatpak-github-actions@47e4de4
?

It's because there isn't a tagged released with 21.08 included. Perhaps there's a way to include commits?

@TheEvilSkeleton
Copy link
Contributor Author

Hmm... I just tried using commits, but that didn't seem to work: https://github.com/TheEvilSkeleton/Leafish/pull/2/checks?check_run_id=3567089753

@iMonZ
Copy link
Contributor

iMonZ commented Sep 10, 2021

Hmm... I just tried using commits, but that didn't seem to work: https://github.com/TheEvilSkeleton/Leafish/pull/2/checks?check_run_id=3567089753

Yeah, they have removed rust as you can see in the link, and they explained how you can use rust in the latest version.
What's actually the current problems before releasing it as a flatpak?

@TheEvilSkeleton
Copy link
Contributor Author

TheEvilSkeleton commented Sep 11, 2021

In the #flatpak Matrix:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants