New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Flatpak #118
Improve Flatpak #118
Conversation
92c6538
to
3e593f3
Compare
I was hoping it was possible to make a cargo subcommand? Or maybe even automatically run it when |
Doesn't that defeat the purpose of reproducible builds? If we run the Python command everytime we try to build it, it will fetch all latest versions, which would make it irreproducible. In that case we can enable network support during build time if you wish. |
Ok so maybe not by default, but a separate cargo subcommand would still be nice (if possible) to ease generation of the right stuff. |
@PureTryOut is this what you were talking about? TheEvilSkeleton@1ebd1e7 FYI: I tested it locally and it worked. |
58ffab5
to
238c2ee
Compare
Not quite, although this is getting close. The script looks good, nice work so far. I meant it'd be great if I could just run a However this scripts works well enough for me already that I'll merge it as is. We can do a cargo subcommand later. |
Hmm... I don't know much about cargo so sadly I cannot really help. |
Thanks @TheEvilSkeleton this project really needed this PR. EDIT: the rust extension was somehow removed. I don't know why and how a workaround is possible. |
It's because there isn't a tagged released with 21.08 included. Perhaps there's a way to include commits? |
Hmm... I just tried using commits, but that didn't seem to work: https://github.com/TheEvilSkeleton/Leafish/pull/2/checks?check_run_id=3567089753 |
Yeah, they have removed rust as you can see in the link, and they explained how you can use rust in the latest version. |
No description provided.