New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Leafish Flatpak #111
Conversation
62eedb8
to
0b2a78e
Compare
1471864
to
07534ac
Compare
I like it so far! CI is failing though. I'm wondering, does this CI workflow push the eventual Flatpak to a repo of some sorts people can use? |
Uh nvm, CI isn't failing, I was looking at an old commit 🙈 So yeah just that question, otherwise this looks good to go. |
Sadly not. We need to create a Flatpak remote for that. For now, we can only manually install using artifacts, see https://github.com/marketplace/actions/flatpak-builder#deployment-stage. |
@TheEvilSkeleton how did you generate |
@PureTryOut this should help you out: https://github.com/flatpak/flatpak-builder-tools/tree/master/cargo If you need help, feel free to ask. |
Interesting. I'm not sure I'm a fan of developers having to install those tools somehow locally and running it every time they want to update some dependency 🤔
Can we not |
It's not really mandatory, but advisable. Now that everyone pushes reproducible builds, we kind of have to do that. If you want, we can give the build system network access, but I would advise against.
Of course we can :) I don't know how to include a single script as a submodule, though. I only know how to use repos as submodules. |
Well you can include the repo as a submodule but then only use the script from it. If that's doable then please add that, it would make it so much easier to change and update deps in the future! |
Closes https://github.com/terrarier2111/Leafish/issues/104.
Since this MR requires approval, test CIs will be available at TheEvilSkeleton#1.