Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Leafish Flatpak #111

Merged
merged 2 commits into from Sep 6, 2021
Merged

Conversation

TheEvilSkeleton
Copy link
Contributor

@TheEvilSkeleton TheEvilSkeleton commented Sep 6, 2021

Closes https://github.com/terrarier2111/Leafish/issues/104.

Since this MR requires approval, test CIs will be available at TheEvilSkeleton#1.

@PureTryOut
Copy link
Collaborator

I like it so far! CI is failing though.

I'm wondering, does this CI workflow push the eventual Flatpak to a repo of some sorts people can use?

@PureTryOut
Copy link
Collaborator

Uh nvm, CI isn't failing, I was looking at an old commit 🙈

So yeah just that question, otherwise this looks good to go.

@TheEvilSkeleton
Copy link
Contributor Author

TheEvilSkeleton commented Sep 6, 2021

I'm wondering, does this CI workflow push the eventual Flatpak to a repo of some sorts people can use?

Sadly not. We need to create a Flatpak remote for that. For now, we can only manually install using artifacts, see https://github.com/marketplace/actions/flatpak-builder#deployment-stage.

@PureTryOut PureTryOut merged commit f44cf08 into Lea-fish:main Sep 6, 2021
@PureTryOut
Copy link
Collaborator

@TheEvilSkeleton how did you generate cargo-sources.json? I wanted to update a dependency but CI now fails because of it not being present in that file 🤔

@TheEvilSkeleton
Copy link
Contributor Author

@PureTryOut this should help you out: https://github.com/flatpak/flatpak-builder-tools/tree/master/cargo

If you need help, feel free to ask.

@PureTryOut
Copy link
Collaborator

PureTryOut commented Sep 7, 2021

Interesting. I'm not sure I'm a fan of developers having to install those tools somehow locally and running it every time they want to update some dependency 🤔

The intended usage of the generators is as a submodule used as part of your build process to generate manifests.

Can we not copy include the script as a submodule and run it as part of some cargo build or cargo run command or something?

@TheEvilSkeleton
Copy link
Contributor Author

TheEvilSkeleton commented Sep 7, 2021

Interesting. I'm not sure I'm a fan of developers having to install those tools somehow locally and running it every time they want to update some dependency thinking

It's not really mandatory, but advisable. Now that everyone pushes reproducible builds, we kind of have to do that. If you want, we can give the build system network access, but I would advise against.

Can we not copy include the script as a submodule and run it as part of some cargo build or cargo run command or something?

Of course we can :)

I don't know how to include a single script as a submodule, though. I only know how to use repos as submodules.

@PureTryOut
Copy link
Collaborator

Well you can include the repo as a submodule but then only use the script from it. If that's doable then please add that, it would make it so much easier to change and update deps in the future!

@TheEvilSkeleton TheEvilSkeleton deleted the flatpak branch September 7, 2021 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Flatpak package
2 participants