Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Flatpak package #104

Closed
TheEvilSkeleton opened this issue Sep 5, 2021 · 12 comments · Fixed by #111
Closed

Make Flatpak package #104

TheEvilSkeleton opened this issue Sep 5, 2021 · 12 comments · Fixed by #111
Assignees
Labels
enhancement New feature or request low-priority Low priority issues

Comments

@TheEvilSkeleton
Copy link
Contributor

TheEvilSkeleton commented Sep 5, 2021

Flatpak is a universal package manager for Linux. Flathub is one of Flatpak's repo (remote) which includes a build system. Alternatively we can use GitHub CI to create Flatpak bundles: https://github.com/marketplace/actions/flatpak-builder.

I'm quite familiar with Flatpak so I can create a manifest.


I don't have a Minecraft account, so I'd like others to test it for me. If you want to test, please read the instructions at https://github.com/terrarier2111/Leafish/issues/104#issuecomment-913779965.

@rowbawts
Copy link

rowbawts commented Sep 5, 2021

I was actually getting ready to suggest this I use Silverblue which "for the most part" requires (prefers) Flatpaks.

@terrarier2111 terrarier2111 added enhancement New feature or request low-priority Low priority issues labels Sep 6, 2021
@PureTryOut
Copy link
Collaborator

I'm quite familiar with Flatpak so I can create a manifest.

Feel free to pick up this issue! I´ve assigned you for now.

@TheEvilSkeleton
Copy link
Contributor Author

TheEvilSkeleton commented Sep 6, 2021

So I just opened MR #111.

I got it working:

image

Icon is looking good:

image

Sadly I do not have a Minecraft account, so if anyone is willing to test it for me, please give some feedback.

@rowbawts
Copy link

rowbawts commented Sep 6, 2021

I'll test, I have a Minecraft account do you have this hosted on the Flathub testing repo?

@TheEvilSkeleton
Copy link
Contributor Author

TheEvilSkeleton commented Sep 6, 2021

I don't want to use Flathub now since I'm waiting for a Leafish release.


You can head over to TheEvilSkeleton#1, click on Details next to Packaging / Flatpak (x86_64) (pull request) (aarch64 for ARM64) at the bottom of the MR. You'll see a "Download artifact" button, so click that and download the zip file. Finally, extract the zip file, go inside the extracted directory if any and run flatpak install leafish.flatpak. You should see a desktop entry after it's installed, and you'll be able to launch it from there. If you want to run from the terminal, run flatpak run com.github.terrarier2111.Leafish.

@rowbawts
Copy link

rowbawts commented Sep 6, 2021

I don't want to use Flathub now since I'm waiting for a Leafish release. You can head over to TheEvilSkeleton#1, click on Details next to Packaging / Flatpak (x86_64) (pull request) (aarch64 for ARM64) at the bottom of the MR. You'll see a "Download artifact" button, so click that and download the zip file. Finally, extract the zip file, go inside the extracted directory if any and run flatpak install leafish.flatpak. You should see a desktop entry after it's installed, and you'll be able to launch it from there.

Ok I've got installed and I'm logged in I will join a server now and report back.

@rowbawts
Copy link

rowbawts commented Sep 6, 2021

Ok so I was able to connect to Hypixel but the cursor doesn't get locked to the window not sure if that's upstream or specific to the Flatpak but bottom line is it works. I'm assuming all other oddities are just non implemented features.

Screenshot from 2021-09-06 13-26-31

@penloy
Copy link

penloy commented Sep 6, 2021

Ok so I was able to connect to Hypixel but the cursor doesn't get locked to the window not sure if that's upstream or specific to the Flatpak but bottom line is it works. I'm assuming all other oddities are just non implemented features.

Screenshot from 2021-09-06 13-26-31

It works for me with cursor locked in the window.

image

@TheEvilSkeleton
Copy link
Contributor Author

Ok so I was able to connect to Hypixel but the cursor doesn't get locked to the window not sure if that's upstream or specific to the Flatpak but bottom line is it works. I'm assuming all other oddities are just non implemented features.

Screenshot from 2021-09-06 13-26-31

Hmm... can you try to download https://github.com/terrarier2111/Leafish/suites/3693742881/artifacts/90071216 and see if you are having this issue in a native binary or not?

@rowbawts
Copy link

rowbawts commented Sep 6, 2021

Ok so I was able to connect to Hypixel but the cursor doesn't get locked to the window not sure if that's upstream or specific to the Flatpak but bottom line is it works. I'm assuming all other oddities are just non implemented features.
Screenshot from 2021-09-06 13-26-31

Hmm... can you try to download https://github.com/terrarier2111/Leafish/suites/3693742881/artifacts/90071216 and see if you are having this issue in a native binary or not?

Same thing in native so that rules that out.

Screenshot from 2021-09-06 13-36-51

@TheEvilSkeleton
Copy link
Contributor Author

TheEvilSkeleton commented Sep 6, 2021

In that case I'd suggest opening a new issue.

Other than that, do they run equally or are there unique problems when using Flatpak?

@rowbawts
Copy link

rowbawts commented Sep 6, 2021

Well I found this I probably should've looked first https://github.com/terrarier2111/Leafish/issues/36

PS: thanks for the edge Flatpak

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low-priority Low priority issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants