Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

No blocks render and impossible to move around on 1.12.2 servers #1

Closed
PureTryOut opened this issue Aug 25, 2021 · 19 comments
Closed

Comments

@PureTryOut
Copy link
Collaborator

I thought I would give Leafish a shot but so far I can't really do anything 馃

Screenshot_20210825_211336

@terrarier2111
Copy link
Member

terrarier2111 commented Aug 26, 2021

That's weird, were you trying with my fist attempt to fix the regression? If so, it might be the issue.

@terrarier2111
Copy link
Member

terrarier2111 commented Aug 26, 2021

Can you give me some information about your system and about the server(version, software etc)?

@terrarier2111
Copy link
Member

terrarier2111 commented Aug 26, 2021

Is the HUD rendering?

@PureTryOut
Copy link
Collaborator Author

I was using 42b3b1f at that time. The server is Cuberite, latest commit from yesterday but I doubt the specific commit matters much. It reports itself and acts as a 1.12.2 server.

The HUD is rendering yes, a buggy inventory and the hotbar appear.

The system it's running on is Alpine Linux and it was compiled with rustc 1.53.0.

@terrarier2111
Copy link
Member

I was using 42b3b1f at that time. The server is Cuberite, latest commit from yesterday but I doubt the specific commit matters much. It reports itself and acts as a 1.12.2 server.

The HUD is rendering yes, a buggy inventory and the hotbar appear.

The system it's running on is Alpine Linux and it was compiled with rustc 1.53.0.

Could you try joining a multiversion server? I was testing on mc-unicat.de, it would be very helpful to see if the issue persists when joining on this server

@PureTryOut
Copy link
Collaborator Author

Ah sorry I should've stated it better, Cuberite accepts any client from 1.8.x to 1.12.x, and Leafish also shows that.

Screenshot_20210826_120902

mc-unicat.de definitely works better, blocks render and I can move around.

@terrarier2111
Copy link
Member

Okay, I suspect it is some bug in my chunk loading code, as i reduced the code duplication, but i never tested anything below 1.15.2 (which is the version Leafish selects for unicat)

@PureTryOut
Copy link
Collaborator Author

That would explain things yes, I'm assuming Leafish selects the highest it can for the server and thus selects 1.12.2 for Cuberite right?

@PureTryOut PureTryOut changed the title No blocks render and impossible to move around No blocks render and impossible to move around on 1.12.2 servers Aug 26, 2021
@terrarier2111
Copy link
Member

terrarier2111 commented Aug 26, 2021

I am not sure about this, as i haven't looked at the multiversion code yet but it would make sense to select the highest version

@PureTryOut
Copy link
Collaborator Author

I... Do not. However I can set one up, assuming it's just for testing. Please tell me your MC nickname so I can whitelist it for you.
Don't expect miracle performances, it'll run on a RockPro64 machine which although more powerful than a RPi also runs other services and might get overloaded at times.

@terrarier2111
Copy link
Member

terrarier2111 commented Aug 26, 2021

ThreadException and terrarier2111 are the two accounts i use for testing (one with real mc and the other with leafish), the performance doesn't really matter :)

@PureTryOut
Copy link
Collaborator Author

Ok got it running.

Use fam-ribbers.com:25564 as the IP. You're whitelisted on both accounts so should be able to join.

@terrarier2111
Copy link
Member

Nice, thanks

@terrarier2111
Copy link
Member

Ok got it running.

Use fam-ribbers.com:25564 as the IP. You're whitelisted on both accounts so should be able to join.

I got it working

@PureTryOut
Copy link
Collaborator Author

Yeah I saw you joining 馃槈 As I said in-game, you're admin so can use relevant commands (use /help to get a list), e.g. to change gamemodes.

@terrarier2111
Copy link
Member

Nice, i mean i got 1.12 fixed

Yeah I saw you joining 馃槈 As I said in-game, you're admin so can use relevant commands (use /help to get a list), e.g. to change gamemodes.

@terrarier2111
Copy link
Member

You should see chunks now

@PureTryOut
Copy link
Collaborator Author

Yup it works, awesome! Solved by 4e59e21

@terrarier2111
Copy link
Member

Yea, i literally just misplaced the unwrap :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants