Getting rid of globals #3

technomancy · 2016-09-18T03:34:24Z

It's rather difficult to follow some of the functionality in the codebase due to the heavy usage of globals.

Cleaning up things to use modules would make it much easier to follow. I may be able to submit a patch for this if you are interested. I have had good luck using luacheck to find globals: https://github.com/mpeterv/luacheck

technomancy · 2016-09-18T03:37:41Z

The problem here is that it would be very likely to conflict with other edits, so maybe we should coordinate about which files to do before beginning.

Rami-Sabbagh · 2016-09-19T11:11:10Z

Fixed in 3c21965 , Carts still have the api as globals (to save code length)

Rami-Sabbagh closed this as completed Sep 19, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Getting rid of globals #3

Getting rid of globals #3

technomancy commented Sep 18, 2016

technomancy commented Sep 18, 2016 •

edited

Rami-Sabbagh commented Sep 19, 2016

Getting rid of globals #3

Getting rid of globals #3

Comments

technomancy commented Sep 18, 2016

technomancy commented Sep 18, 2016 • edited

Rami-Sabbagh commented Sep 19, 2016

technomancy commented Sep 18, 2016 •

edited