New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: 💡 maybe perf a bit #7

Merged

HerringtonDarkholme merged 1 commit into HerringtonDarkholme:main from IWANABETHATGUY:refactor-codegen

Sep 9, 2021

Contributor

IWANABETHATGUY commented Sep 9, 2021

No description provided.


          refactor: 💡 maybe perf a bit

cab3c98

HerringtonDarkholme approved these changes

View reviewed changes

IWANABETHATGUY commented

View reviewed changes

src/core/codegen.rs

@@ @@ -58,11 +58,12 @@ pub trait CodeGenWrite: Write { @@
                       for c in s.chars() {
                           if !is_boundary && c.is_ascii_uppercase() {
                               self.write_char('-')?;
-                              self.write_char((c as u8 - b'A' + b'a') as char)?;
+                              self.write_char(c.to_ascii_lowercase())?;
+                              is_boundary = false;

Contributor Author

IWANABETHATGUY Sep 9, 2021

in this branch, is_boundry will always be false, due to c.is_ascii_alphanumeric is true.

HerringtonDarkholme merged commit c6b0467 into HerringtonDarkholme:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment