Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup github actions #5

Merged
merged 1 commit into from Sep 3, 2021
Merged

Setup github actions #5

merged 1 commit into from Sep 3, 2021

Conversation

zhmushan
Copy link
Contributor

@zhmushan zhmushan commented Sep 3, 2021

No description provided.

@zhmushan
Copy link
Contributor Author

zhmushan commented Sep 3, 2021

@HerringtonDarkholme Any ideas on fixing the diverging_sub_expression error?

@HerringtonDarkholme
Copy link
Owner

Thanks for setting up GH actions!
These are inherently todo and I need to implement them.

@zhmushan
Copy link
Contributor Author

zhmushan commented Sep 3, 2021

Consider merging this PR? Although it can only be red before todo is implemented

@HerringtonDarkholme HerringtonDarkholme merged commit 316d355 into HerringtonDarkholme:main Sep 3, 2021
@zhmushan zhmushan deleted the gh_actions branch September 3, 2021 05:55
@zhmushan
Copy link
Contributor Author

zhmushan commented Sep 3, 2021

@HerringtonDarkholme This rule does not prohibit todo!(). This error is caused by passing todo!() to emit_error. It should be SourceLocation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants