馃幐 refactor #4
Merged
馃幐 refactor #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IWANABETHATGUY
commented
Sep 2, 2021
src/core/codegen.rs
Outdated
| @@ -9,21 +9,21 @@ pub trait CodeGenerator { | |||
| } | |||
|
|
|||
| pub fn generate(node: IRNode) { | |||
| use IRNode as IR; | |||
| use IRNode::*; | |||
There was a problem hiding this comment.
only use * in this scope, so namespace conflict is not need to be concered.
the context is clear here, IR:: looks redundant
There was a problem hiding this comment.
Thanks! But the IR is defined in another file so I would want to use wildcard importing only when the definition is in the same file.
There was a problem hiding this comment.
i have removed all the wildcard import
HerringtonDarkholme
approved these changes
Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor