Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't segfault when process terminates #13

Merged
merged 1 commit into from Sep 3, 2021
Merged

don't segfault when process terminates #13

merged 1 commit into from Sep 3, 2021

Conversation

grtcdr
Copy link
Contributor

@grtcdr grtcdr commented Sep 3, 2021

Hi :)

I'm not sure if you were able to reproduce this on your end, but when I kill the process the compiler throws:

thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', src/main.rs:329:61
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
zsh: segmentation fault (core dumped)  ./hebi

This PR should fix that.

@ElnuDev
Copy link
Owner

ElnuDev commented Sep 3, 2021

Hm that's interesting. I always get a clean output on exit, regardless of whether it is through closing the window or interrupting the process in the command line. You're on Linux, right? I am as well. Anyhow, I'll merge this in! 👍

@ElnuDev ElnuDev merged commit 7ffe6dc into ElnuDev:main Sep 3, 2021
@grtcdr
Copy link
Contributor Author

grtcdr commented Sep 3, 2021

You're on Linux

I am, I suppose Qtile could be the culprit. It has its own kill method, but I'm not exactly sure.

Anyhow, I'll merge this in!

Thank you, it's one less unwrap() :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@grtcdr @ElnuDev