Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use .wav audio directly instead of converting to .mp3 #12

Closed
ElnuDev opened this issue Sep 2, 2021 · 3 comments
Closed

Use .wav audio directly instead of converting to .mp3 #12

ElnuDev opened this issue Sep 2, 2021 · 3 comments
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed

Comments

@ElnuDev
Copy link
Owner

ElnuDev commented Sep 2, 2021

Currently, the .wav files in the dev_assets folder cause errors when used, even with the wav feature of Bevy enabled. See this thread on the Bevy Discord server for more info. The files seem to play fine, so I'm not sure if this is some issue with the encoding of the files that jsfxr outputs, or if there's a potential bug in Bevy. Either way, it'd be way cleaner use the original .wav files directly instead of having to convert them .mp3 using a shell script like is being done currently and store both in this repository.
@ElnuDev ElnuDev added bug Something isn't working enhancement New feature or request help wanted Extra attention is needed labels Sep 2, 2021
@grtcdr
Copy link
Contributor

grtcdr commented Sep 3, 2021

You're going to want to look into rodio which is an abstraction (extension?) over many audio encoders/decoders, namely hound for the WAV format.

ElnuDev added a commit that referenced this issue Sep 3, 2021
@ElnuDev
reslove #12
6ef670c
@ElnuDev ElnuDev closed this as completed in 1ea96dc Sep 3, 2021
@ElnuDev
Copy link
Owner Author

ElnuDev commented Sep 3, 2021

There was an issue with jsfxr — one of the community members on the Bevy Discord fixed the issue with this PR, and is now live on the site. Hebi is now using the fixed .wav files directly, but keeping the mp3 feature of Bevy in case the user wants to use .mp3 files.

@grtcdr
Copy link
Contributor

grtcdr commented Sep 4, 2021

Good to hear :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ElnuDev @grtcdr